Use pnpm instead of npm in check-data-files.mjs#881
Merged
IEvangelist merged 1 commit intomicrosoft:mainfrom May 8, 2026
Merged
Use pnpm instead of npm in check-data-files.mjs#881IEvangelist merged 1 commit intomicrosoft:mainfrom
IEvangelist merged 1 commit intomicrosoft:mainfrom
Conversation
The repository is configured as a pnpm workspace (pnpm-workspace.yaml, pnpm-lock.yaml, packageManager: pnpm@10.30.1), but check-data-files.mjs hardcoded `npm run update:all`. Running npm inside a pnpm workspace ignores pnpm-lock.yaml, creates an unnecessary package-lock.json, and can corrupt or destabilize the local development environment. Fixes microsoft#872 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the frontend “missing data files” safety check to keep all script execution inside the repo’s pnpm workspace, avoiding npm lockfile/node_modules side effects.
Changes:
- Switch
check-data-files.mjsto runpnpm run update:allinstead ofnpm run update:all.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
davidfowl
approved these changes
May 8, 2026
davidfowl
added a commit
that referenced
this pull request
May 8, 2026
* chore: Update integration data and GitHub stats (5/7/26) (#882) Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use pnpm instead of npm in check-data-files.mjs (#881) The repository is configured as a pnpm workspace (pnpm-workspace.yaml, pnpm-lock.yaml, packageManager: pnpm@10.30.1), but check-data-files.mjs hardcoded `npm run update:all`. Running npm inside a pnpm workspace ignores pnpm-lock.yaml, creates an unnecessary package-lock.json, and can corrupt or destabilize the local development environment. Fixes #872 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: Update integration data and GitHub stats (5/8/26) (#890) Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add Hot Reload and watch guidance (#887) * Add Hot Reload and watch guidance Document Aspire watch behavior for AppHost changes, resource-specific restart and rebuild workflows, and IDE-managed hot reload/debugging boundaries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify dotnet watch AppHost behavior Document current dotnet watch behavior for Aspire AppHosts and .NET project resources, including restart behavior and known quirks requiring explicit restart or rebuild commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify C# projects watch guidance Rename the project resources tab to C# projects and tighten the dotnet watch wording around C# project behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Refine C# dotnet watch guidance Lead the C# projects section with dotnet watch support for C# AppHosts and move current experience quirks into an Important note. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Reduce C# watch guidance repetition Tighten the C# projects section so dotnet watch support and defaultWatchEnabled behavior are not repeated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update standalone dashboard docs for Aspire CLI (#886) * Update standalone dashboard docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Centralize standalone dashboard prerequisites Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore dashboard landing quick start Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address dashboard quick start feedback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix terminal tabs regression test source Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix standalone dashboard telemetry limits link Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Show both dashboard quick start options Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address standalone dashboard review feedback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: David Pine <david.pine@microsoft.com>
Copilot AI
pushed a commit
that referenced
this pull request
May 9, 2026
* chore: Update integration data and GitHub stats (5/7/26) (#882) Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use pnpm instead of npm in check-data-files.mjs (#881) The repository is configured as a pnpm workspace (pnpm-workspace.yaml, pnpm-lock.yaml, packageManager: pnpm@10.30.1), but check-data-files.mjs hardcoded `npm run update:all`. Running npm inside a pnpm workspace ignores pnpm-lock.yaml, creates an unnecessary package-lock.json, and can corrupt or destabilize the local development environment. Fixes #872 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: Update integration data and GitHub stats (5/8/26) (#890) Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add Hot Reload and watch guidance (#887) * Add Hot Reload and watch guidance Document Aspire watch behavior for AppHost changes, resource-specific restart and rebuild workflows, and IDE-managed hot reload/debugging boundaries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify dotnet watch AppHost behavior Document current dotnet watch behavior for Aspire AppHosts and .NET project resources, including restart behavior and known quirks requiring explicit restart or rebuild commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify C# projects watch guidance Rename the project resources tab to C# projects and tighten the dotnet watch wording around C# project behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Refine C# dotnet watch guidance Lead the C# projects section with dotnet watch support for C# AppHosts and move current experience quirks into an Important note. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Reduce C# watch guidance repetition Tighten the C# projects section so dotnet watch support and defaultWatchEnabled behavior are not repeated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update standalone dashboard docs for Aspire CLI (#886) * Update standalone dashboard docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Centralize standalone dashboard prerequisites Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore dashboard landing quick start Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address dashboard quick start feedback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix terminal tabs regression test source Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix standalone dashboard telemetry limits link Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Show both dashboard quick start options Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address standalone dashboard review feedback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: David Pine <david.pine@microsoft.com> Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #872
The repository is configured as a
pnpmworkspace (pnpm-workspace.yaml,pnpm-lock.yaml,"packageManager": "pnpm@10.30.1"), butsrc/frontend/scripts/check-data-files.mjshardcoded:When
pnpm devis run and missing data files are detected, the script jumps out of the activepnpmenvironment and forcesnpm run update:all. Runningnpminside apnpmworkspace:pnpm-lock.yamlpackage-lock.jsonnode_modulesstructureChange
This repo is intended to strictly use
pnpm(it ships apnpm-workspace.yamland pinspackageManagertopnpm@10.30.1), so the script now invokespnpmdirectly:This keeps the call site simple and matches every other script invocation in
src/frontend/package.json(dev,start,build,lint,test,update:all, etc. all usepnpm).