Skip to content

Don't start watching console logs if an existing resource isn't selected #1055

@tlmii

Description

@tlmii

From #1034 (comment)

When you click on the console logs link in the menu, what decides which app to display?

Structured logs and traces have an "All" option and select it by default. But that doesn't make sense for console logs. Metrics doesn't display anything by default and prompts you to choose a service (note: service should be renamed to resource)

image

I think the console logs could do the same thing. That page would also be displayed if a bad name is in the url, e.g. http://localhost:15888/ConsoleLogs/ThisDoesntExist

This is relevant with or without the combined console logs view (#1034 which as of this issue being filed has not gone in) since the behavior is the same before and after that PR.

@leslierichardson95 @kvenkatrajan for your thoughts on this as well

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions