Rename MessageBar interaction to Notification#10449
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames "MessageBar" to "Notification" throughout the Aspire codebase to improve naming clarity based on user feedback. The change affects the interaction service API and all related components.
Key changes:
- Renamed
PromptMessageBarAsyncmethod toPromptNotificationAsyncacross all implementations - Updated class names from
MessageBarInteractionOptionstoNotificationInteractionOptionsandMessageBarInteractionInfotoNotificationInteractionInfo - Modified protobuf definitions to use
InteractionNotificationinstead ofInteractionMessageBar
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting/IInteractionService.cs | Updated interface method signature and class names for notification interactions |
| src/Aspire.Hosting/InteractionService.cs | Renamed implementation methods and internal classes from MessageBar to Notification |
| src/Aspire.Hosting/Dashboard/proto/dashboard_service.proto | Updated protobuf message definitions and field names for notifications |
| src/Aspire.Hosting/Dashboard/DashboardService.cs | Updated service implementation to use new notification class names |
| src/Aspire.Hosting/Dashboard/DashboardServiceData.cs | Updated request handling to use notification instead of message bar |
| src/Aspire.Dashboard/Components/Interactions/InteractionsProvider.cs | Updated dashboard component to handle notification interactions |
| src/Aspire.Hosting/VersionChecking/VersionCheckService.cs | Updated method calls to use new notification API |
| src/Aspire.Hosting/Orchestrator/ParameterProcessor.cs | Updated method calls to use new notification API |
| src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs | Updated method calls to use new notification API |
| tests/Shared/TestInteractionService.cs | Updated test implementation method signature |
| tests/Aspire.Hosting.Tests/InteractionServiceTests.cs | Updated test method calls |
| playground/Stress/Stress.AppHost/InteractionCommands.cs | Updated playground examples to use new notification API |
Comments suppressed due to low confidence (2)
src/Aspire.Hosting/Dashboard/proto/dashboard_service.proto:361
- [nitpick] The field name should use camelCase instead of snake_case to be consistent with other protobuf field naming conventions in the codebase.
string link_text = 3;
src/Aspire.Hosting/Dashboard/proto/dashboard_service.proto:362
- [nitpick] The field name should use camelCase instead of snake_case to be consistent with other protobuf field naming conventions in the codebase.
string link_url = 4;
davidfowl
approved these changes
Jul 16, 2025
Member
Author
|
/backport to release/9.4 |
Contributor
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16312952806 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename message bar to notification. Feedback from user.
Addresses #10427
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate