Skip to content

Rename MessageBar interaction to Notification#10449

Merged
JamesNK merged 1 commit intomainfrom
jamesnk/interaction-notification
Jul 16, 2025
Merged

Rename MessageBar interaction to Notification#10449
JamesNK merged 1 commit intomainfrom
jamesnk/interaction-notification

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 16, 2025

Description

Rename message bar to notification. Feedback from user.

Addresses #10427

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK added this to the 9.4 milestone Jul 16, 2025
@JamesNK JamesNK requested review from Copilot and davidfowl July 16, 2025 05:13
@JamesNK JamesNK requested review from eerhardt and radical as code owners July 16, 2025 05:13
@JamesNK JamesNK requested a review from mitchdenny as a code owner July 16, 2025 05:13
@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jul 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames "MessageBar" to "Notification" throughout the Aspire codebase to improve naming clarity based on user feedback. The change affects the interaction service API and all related components.

Key changes:

  • Renamed PromptMessageBarAsync method to PromptNotificationAsync across all implementations
  • Updated class names from MessageBarInteractionOptions to NotificationInteractionOptions and MessageBarInteractionInfo to NotificationInteractionInfo
  • Modified protobuf definitions to use InteractionNotification instead of InteractionMessageBar

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Aspire.Hosting/IInteractionService.cs Updated interface method signature and class names for notification interactions
src/Aspire.Hosting/InteractionService.cs Renamed implementation methods and internal classes from MessageBar to Notification
src/Aspire.Hosting/Dashboard/proto/dashboard_service.proto Updated protobuf message definitions and field names for notifications
src/Aspire.Hosting/Dashboard/DashboardService.cs Updated service implementation to use new notification class names
src/Aspire.Hosting/Dashboard/DashboardServiceData.cs Updated request handling to use notification instead of message bar
src/Aspire.Dashboard/Components/Interactions/InteractionsProvider.cs Updated dashboard component to handle notification interactions
src/Aspire.Hosting/VersionChecking/VersionCheckService.cs Updated method calls to use new notification API
src/Aspire.Hosting/Orchestrator/ParameterProcessor.cs Updated method calls to use new notification API
src/Aspire.Hosting.Azure/Provisioning/Internal/DefaultProvisioningContextProvider.cs Updated method calls to use new notification API
tests/Shared/TestInteractionService.cs Updated test implementation method signature
tests/Aspire.Hosting.Tests/InteractionServiceTests.cs Updated test method calls
playground/Stress/Stress.AppHost/InteractionCommands.cs Updated playground examples to use new notification API
Comments suppressed due to low confidence (2)

src/Aspire.Hosting/Dashboard/proto/dashboard_service.proto:361

  • [nitpick] The field name should use camelCase instead of snake_case to be consistent with other protobuf field naming conventions in the codebase.
    string link_text = 3;

src/Aspire.Hosting/Dashboard/proto/dashboard_service.proto:362

  • [nitpick] The field name should use camelCase instead of snake_case to be consistent with other protobuf field naming conventions in the codebase.
    string link_url = 4;

@JamesNK JamesNK merged commit b154569 into main Jul 16, 2025
277 checks passed
@JamesNK JamesNK deleted the jamesnk/interaction-notification branch July 16, 2025 07:14
@JamesNK
Copy link
Member Author

JamesNK commented Jul 16, 2025

/backport to release/9.4

@github-actions
Copy link
Contributor

Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16312952806

@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication area-dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants