Rename EventingExtensions class to DistributedApplicationEventingExtensions#10688
Merged
mitchdenny merged 2 commits intomainfrom Jul 28, 2025
Merged
Conversation
…nsions and update file name Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename EventingExtensions to DistributedApplicationEventingExtensions throughout Aspire 9.4
Rename EventingExtensions class to DistributedApplicationEventingExtensions
Jul 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the EventingExtensions class to DistributedApplicationEventingExtensions to provide a more descriptive and specific name that clearly indicates its purpose for distributed application resource eventing within the Aspire hosting framework.
Key Changes:
- Renamed class from
EventingExtensionstoDistributedApplicationEventingExtensions - Renamed corresponding file to match the new class name
- Maintained all existing extension method functionality
Comments suppressed due to low confidence (1)
src/Aspire.Hosting/DistributedApplicationEventingExtensions.cs:12
- [nitpick] The new class name
DistributedApplicationEventingExtensionsis quite long and may impact readability. Consider a more concise alternative likeDistributedAppEventingExtensionsorAppEventingExtensionswhile still maintaining clarity about its purpose.
public static class DistributedApplicationEventingExtensions
Member
|
LGTM |
mitchdenny
approved these changes
Jul 28, 2025
Member
|
/backport to release/9.4 |
Contributor
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16559154000 |
Contributor
|
This would need to be in 9.4 since this is not experimental. |
Member
|
Yep backporting now. |
eerhardt
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
EventingExtensionsclass toDistributedApplicationEventingExtensionsto provide a more descriptive and specific name that clearly indicates its purpose and scope within the Aspire hosting framework.Changes Made
EventingExtensionstoDistributedApplicationEventingExtensionsin the source fileEventingExtensions.cstoDistributedApplicationEventingExtensions.csto match the new class nameImpact
This is a non-breaking change for consumers of the library because:
OnBeforeResourceStarted,OnConnectionStringAvailable,OnInitializeResource,OnResourceEndpointsAllocated,OnResourceReady) remain functionally identicalVerification
The new name
DistributedApplicationEventingExtensionsbetter reflects that these are extension methods specifically for distributed application resource eventing, making the codebase more maintainable and self-documenting.This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.