Rename CompletePublishAsync to CompleteAsync in IPublishingActivityReporter

[Copilot]

This PR renames the CompletePublishAsync method to CompleteAsync on the IPublishingActivityReporter interface and its implementation to improve API consistency and naming clarity.

Background

The IPublishingActivityReporter interface had a method named CompletePublishAsync that signals when the entire publishing process has completed. However, this naming was inconsistent with other completion methods in the codebase, such as IPublishingStep.CompleteAsync and PublishingTask.CompleteAsync, which use the simpler CompleteAsync naming pattern.

Changes

• Interface: Renamed CompletePublishAsync to CompleteAsync in IPublishingActivityReporter
• Implementation: Updated method implementation in PublishingActivityReporter class
• Call Sites: Updated 2 method calls in DistributedApplicationRunner.cs
• Tests: Updated 5 test method names and 10 method calls in PublishingActivityReporterTests.cs

Verification

• ✅ No naming conflicts with existing CompleteAsync methods (they exist on different types)
• ✅ All builds compile successfully without errors or warnings
• ✅ XML documentation preserved and correctly generated
• ✅ No remaining references to the old method name in source code

The method signature and behavior remain unchanged - this is purely a naming improvement for consistency across the publishing API.

This pull request was created as a result of the following prompt from Copilot chat.

Rename the method CompletePublishAsync to CompleteAsync on the IPublishingActivityReporter and its implementation(s). Update all call sites, documentation comments, and tests accordingly to use the new method name. Ensure consistency across the codebase and verify that the new method name does not create ambiguities or conflicts with existing methods (such as other CompleteAsync overloads).

Steps:

• Locate the CompletePublishAsync method on IPublishingActivityReporter (and implementation, likely PublishingActivityReporter).
• Rename CompletePublishAsync to CompleteAsync in the interface and all implementing classes.
• Update all call sites in the codebase to use the new method name.
• Update any XML documentation or comments referencing CompletePublishAsync.
• Update any affected tests.
• Ensure the build passes and there are no ambiguous overloads or naming conflicts as a result of the rename.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[mitchdenny]

@captainsafia at one point I felt strongly that we should rename CompletePublishAsync to CompleteAsync but given you've been closer to this lately I'll let you make the call on this. For now I'm closing this very stale PR.

[captainsafia]

@captainsafia at one point I felt strongly that we should rename CompletePublishAsync to CompleteAsync but given you've been closer to this lately I'll let you make the call on this. For now I'm closing this very stale PR.

I agree with you, especially given that we've now made it so that deploy doesn't implicitly run publish. We can resolve this once the API surface for this area has stabilized and we're taking the experiemental attribute off of things.