Skip to content

Add theme manager and update chart on change#1089

Merged
JamesNK merged 2 commits intomainfrom
jamesnk/graph-theme
Nov 30, 2023
Merged

Add theme manager and update chart on change#1089
JamesNK merged 2 commits intomainfrom
jamesnk/graph-theme

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Nov 29, 2023

Fixes #401

  • Added a ThemeManager that allows for other components to react to the theme changing.
  • Chart now tracks what theme it was rendered with and re-renders if it changes

Demo:
chart-theme

Comment thread src/Aspire.Dashboard/Model/ThemeManager.cs
Comment thread src/Aspire.Dashboard/Model/ThemeManager.cs Outdated
Comment thread src/Aspire.Dashboard/Model/ThemeManager.cs Outdated
@JamesNK JamesNK merged commit 27c746f into main Nov 30, 2023
@JamesNK JamesNK deleted the jamesnk/graph-theme branch November 30, 2023 08:10
andrevlins pushed a commit to andrevlins/aspire that referenced this pull request Dec 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire] Under 'Metrics' of dashboard, some contents cannot catch up with the theme changes, hard to read and need to refresh the page.

3 participants