Update FluentUI packages to 4.1.1#1152
Merged
Merged
Conversation
tlmii
requested review from
JamesNK,
adamint,
drewnoakes,
smitpatel and
vnbaaij
vnbaaij
reviewed
Nov 30, 2023
Contributor
vnbaaij
left a comment
vnbaaij
left a comment
There was a problem hiding this comment.
Maybe hold off on merging this one and go with 4.1.1 of Fluent UI package (which has the Splitter fix)
vnbaaij
approved these changes
Nov 30, 2023
tlmii
changed the title
smitpatel
approved these changes
Nov 30, 2023
andrevlins
pushed a commit
to andrevlins/aspire
that referenced
this pull request
Dec 3, 2023
* Update FluentUI packages to 4.1 * Update to 4.1.1 and remove workaround
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #865, Fixes #866
Added minimum widths of 150px to each part of the Summary/Details view now that that support is available per the original suggestion in #865. I think we can get feedback on whether those are appropriate values or whether they should be configurable but it is a good start to clean up the interface.
There's a bug in the FluentSplitter implementation here that causes the splitter bar to not be rendered properly. I put a workaround in that we can remove once microsoft/fluentui-blazor#1046 (or a similar PR fixing that issue) is available to us.