Workaround container networking limitations#1203
Conversation
ghost
added
the
area-app-model
|
Taking bets on how long this work around will hang around for? |
| // PrepareProxylessServices(); | ||
|
|
||
| await CreateContainerSingletonsAsync(cancellationToken).ConfigureAwait(false); | ||
| // await CreateContainerSingletonsAsync(cancellationToken).ConfigureAwait(false); | ||
|
|
There was a problem hiding this comment.
@bwateratmsft @karolz-ms I ended up disabling this to make the PR work. Any guidance here on how this is supposed to work would be appreciated.
There was a problem hiding this comment.
We had a conversation about this in #886. Long story short, we need more time and design to enable this.
There was a problem hiding this comment.
FYI unused code was causing code analysis warnings. I've removed it here - #1286. Source is still available in the file history 😄
| // PrepareProxylessServices(); | ||
|
|
||
| await CreateContainerSingletonsAsync(cancellationToken).ConfigureAwait(false); | ||
| // await CreateContainerSingletonsAsync(cancellationToken).ConfigureAwait(false); | ||
|
|
There was a problem hiding this comment.
We had a conversation about this in #886. Long story short, we need more time and design to enable this.
- Until we setup container networking, make sure containers can talk to other containers when using WithReference. This won't work when using raw strings/urls.
davidfowl
force-pushed
the
davidfowl/container-networking
branch
from
6d5bb03 to
0958953
Compare
|
cc @eerhardt This change disables proxyless containers for preview2 until we have more runway to fix the other issues |
4 participants
Preview2 mitigation for #128
Fixes #1197