Honour GridValue.MaxDisplayLength#1224
Merged
tlmii merged 3 commits intomicrosoft:mainfrom Dec 6, 2023
Merged
Conversation
This code appears to have been written to allow customizing the maximum display length. The value was never read, so the default (8) always be used. This change fixes that.
ghost
added
the
tlmii
reviewed
Dec 6, 2023
Member
tlmii
left a comment
tlmii
left a comment
There was a problem hiding this comment.
Good catch on this not being used. One real comment though.
drewnoakes
commented
Dec 6, 2023
tlmii
approved these changes
Dec 6, 2023
Member
|
@joperezr It looks like this PR is stuck like another one earlier today. It's fine to merge now, or if you can unstick it for us we can merge? |
Member
|
Looks like closing and reopening the PR kicked the build off. |
Member
Good to know - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code appears to have been written to allow customizing the maximum display length. The value was never read, so the default (8) always be used. This change fixes that.