Fix build break after merge conflict#1245
Merged
joperezr merged 3 commits intomicrosoft:mainfrom Dec 6, 2023
Merged
Conversation
ghost
added
the
adamint
approved these changes
Dec 6, 2023
joperezr
approved these changes
Dec 6, 2023
smitpatel
approved these changes
Dec 6, 2023
Member
|
The code coverage break we are getting is unrelated to the break you are fixing here @tlmii, would you mind if I push a change here to fix that other code coverage break too? |
Member
Author
|
Nope, go ahead. |
joperezr
force-pushed
the
dev/fix-build-break
branch
from
8eb3b42 to
b40cc5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I merged #1231 I didn't realize that #1229 was merged a couple hours before and it removed
SelectedResourceNamein favor ofSelectedResource. Small fix to useSelectedResourceinstead.