Fix pip+pyproject.toml apps missing install commands in generated Dockerfile#12876
Merged
Fix pip+pyproject.toml apps missing install commands in generated Dockerfile#12876
Conversation
Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix dockerfile to include pip install command
Fix pip+pyproject.toml apps missing install commands in generated Dockerfile
Nov 10, 2025
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12876Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12876" |
davidfowl
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python apps using pip with
pyproject.toml(withoutrequirements.txt) were generating Dockerfiles without dependency installation commands, causing build failures. At runtime,pip install .executes automatically whenpyproject.tomlis detected, but this wasn't reflected in published Dockerfiles.Fixes #8625
Changes
Modified
GenerateFallbackDockerfileto check forpyproject.tomland generate appropriate install commands:Priority:
requirements.txt>pyproject.toml> none, matching runtime behavior.Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplateOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.