Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13107Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13107" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a functional test to verify that the container tunnel feature works correctly with YARP (Yet Another Reverse Proxy). The test ensures that when the container tunnel is enabled, YARP can properly route requests to a containerized service.
Key Changes
- Added a new test class
ContainerTunnelTestswith one test method that verifies container tunnel functionality with YARP - Updated project references to include the YARP hosting package
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/ContainerTunnelTests.cs | New test file that verifies container tunnel works with YARP by configuring a route through YARP to ServiceA and asserting the response |
| tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj | Added project reference to Aspire.Hosting.Yarp to support YARP testing functionality |
danegsta
approved these changes
Nov 22, 2025
Contributor
|
@radical this will break on helix right? |
Contributor
Author
|
@davidfowl the test is marked as |
radical
pushed a commit
that referenced
this pull request
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test that verifies basic functionality of the container tunnel.