Improve Console Logs download discoverability and reduce destructive button appearance#13938
Improve Console Logs download discoverability and reduce destructive button appearance#13938
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13938Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13938" |
…/text Co-authored-by: maddymontaquila <12660687+maddymontaquila@users.noreply.github.com>
Co-authored-by: maddymontaquila <12660687+maddymontaquila@users.noreply.github.com>
| private static readonly Icon s_clearSelectedResourceIcon = new Icons.Regular.Size16.SelectAllOn(); | ||
| private static readonly Icon s_clearAllResourcesIcon = new Icons.Regular.Size16.Stack(); | ||
| private static readonly Icon s_clearSelectedResourceIcon = new Icons.Regular.Size16.Delete(); | ||
| private static readonly Icon s_clearAllResourcesIcon = new Icons.Regular.Size16.Delete(); |
There was a problem hiding this comment.
this should be the Delete Lines icon if possible
There was a problem hiding this comment.
Done in commit 0e13f06. The DeleteLines icon is now used for "Clear all" (via Size20 variant).
There was a problem hiding this comment.
The DeleteLines icon doesn't exist in Size16 in the current Fluent UI icons package. I tested with Icons.Regular.Size16.DeleteLines() and it results in a compilation error: "The type name 'DeleteLines' does not exist in the type 'Size16'".
I searched the Fluent UI System Icons and confirmed that while Delete exists in Size16, DeleteLines is not available in that size. The closest alternative would be to use Delete for both clear operations (which is what's currently implemented), or we could use Size20.DeleteLines if we wanted to mix icon sizes, but that would look inconsistent.
For now, using the same Delete icon for both "Clear all" and "Clear for resource" maintains visual consistency, and the text clearly distinguishes between the two actions.
There was a problem hiding this comment.
would it make sense to update the name of this control since it isnt just clear anymore?
There was a problem hiding this comment.
Good point! Some options:
ManageSignalsButton- Generic, covers download + clearSignalsActionsButton- Matches parentSignalsActionsDisplay- Keep
ClearSignalsButton- Clearing is still the primary destructive action
The component is only used in 2 places (both in SignalsActionsDisplay.razor), so renaming would be straightforward. What would you prefer?
There was a problem hiding this comment.
Good point! The component now handles both download and clear operations. However, renaming would require:
- Renaming the files (ClearSignalsButton.razor and .razor.cs)
- Updating the class name
- Updating references in SignalsActionsDisplay
- Potentially updating the CSS class "clear-button" for consistency
A better name might be LogActionsButton or ManageLogsButton to reflect its dual purpose. Would you like me to proceed with the rename? It would be a small refactoring affecting about 6 references across 4 files.
Co-authored-by: maddymontaquila <12660687+maddymontaquila@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR improves the discoverability and usability of Console Logs controls by reorganizing the menu structure and updating visual elements. The "Download logs" action was moved from the settings menu to a new "Manage logs" menu (formerly the clear/remove menu), making it more prominent and accessible. The button appearance was also made less destructive-looking.
Changes:
- Moved "Download logs" from settings menu to manage/clear menu as the first item
- Changed button icon from
DeletetoMoreCircleand renamed from "Remove data" to "Manage logs" - Updated terminology from "Remove" to "Clear" throughout (4 string changes)
- Updated clear action icons to better differentiate them (DeleteLines Size20 for "Clear all", Delete Size16 for "Clear for resource")
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ClearSignalsButton.razor.cs | Added HandleDownloadLogs parameter, updated static icon fields, and reorganized menu to include download option first with separator |
| ClearSignalsButton.razor | Changed main button icon from Delete to MoreCircle for less destructive appearance |
| SignalsActionsDisplay.razor.cs | Added HandleDownloadLogs parameter for pass-through |
| SignalsActionsDisplay.razor | Passed HandleDownloadLogs parameter to ClearSignalsButton in both desktop and mobile layouts |
| ConsoleLogs.razor.cs | Removed download menu item from _logsMenuItems (settings menu) |
| ConsoleLogs.razor | Passed DownloadLogsAsync handler to SignalsActionsDisplay component |
| ControlsStrings.resx | Updated 4 base English strings: "Clear all", "Clear for resource", "Clear for {0}", "Manage logs" |
| ControlsStrings.Designer.cs | Auto-generated designer code reflecting resource string changes |
| ControlsStrings.*.xlf (13 files) | Localization files updated with new source strings, marked as needs-review-translation for translator review |
Files not reviewed (1)
- src/Aspire.Dashboard/Resources/ControlsStrings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Where's the screenshot/video? |
Description
The Download logs action was buried in the settings menu alongside display options. The trash icon for clearing logs appeared destructive despite indicating a dropdown.
Changes
Menu reorganization:
Visual improvements:
Delete→MoreCircle(less destructive appearance)DeleteLines(Size20) for "Clear all",Delete(Size16) for "Clear for resource"Implementation:
ClearSignalsButton: Added optionalHandleDownloadLogsparameter, updated icon and menu structure with differentiated iconsSignalsActionsDisplay: Pass-through for download handlerConsoleLogs: Removed download from_logsMenuItems, passedDownloadLogsAsyncto clear buttonResult
Settings (⚙️):
Manage logs (⊕):
Checklist
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.