[release/13.2] API Review Feedback#15370
Merged
joperezr merged 2 commits intomicrosoft:release/13.2from Mar 19, 2026
Merged
Conversation
Fixing some API review comments.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15370Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15370" |
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses API review feedback around Azure private endpoint support by reducing redundant interface implementations and consolidating namespace usage for the notification interface.
Changes:
- Removed redundant
IAzurePrivateEndpointTarget.Idexplicit implementations from multiple Azure resource types where a suitableIdproperty already exists. - Moved
IAzurePrivateEndpointTargetNotificationinto theAspire.Hosting.Azurenamespace and cleaned up now-unnecessaryusingdirectives.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.WebPubSub/AzureWebPubSubResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs | Removes redundant explicit Id implementation and a now-unused namespace import. |
| src/Aspire.Hosting.Azure.SignalR/AzureSignalRResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.Search/AzureSearchResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.Redis/AzureManagedRedisResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.PostgreSQL/AzurePostgresFlexibleServerResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.Network/IAzurePrivateEndpointTargetNotification.cs | Changes namespace to Aspire.Hosting.Azure for API shaping/consistency. |
| src/Aspire.Hosting.Azure.Network/AzurePrivateEndpointExtensions.cs | Cleans up unused using after namespace adjustment. |
| src/Aspire.Hosting.Azure.KeyVault/AzureKeyVaultResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.EventHubs/AzureEventHubsResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.CosmosDB/AzureCosmosDBResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
| src/Aspire.Hosting.Azure.AppConfiguration/AzureAppConfigurationResource.cs | Removes redundant explicit IAzurePrivateEndpointTarget.Id implementation. |
joperezr
approved these changes
Mar 18, 2026
Member
joperezr
reviewed
Mar 18, 2026
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Member
Author
Member
|
Is this ready to get merged Eric? |
adamint
approved these changes
Mar 19, 2026
Member
Author
Yes, I believe so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some API review comments.