[release/13.2] Fix dashboard GitHub Copilot integration#15381
Merged
joperezr merged 4 commits intorelease/13.2from Mar 19, 2026
Merged
[release/13.2] Fix dashboard GitHub Copilot integration#15381joperezr merged 4 commits intorelease/13.2from
joperezr merged 4 commits intorelease/13.2from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15381Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15381" |
JamesNK
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Aspire Dashboard GitHub Copilot (GHCP) assistant integration by aligning package versions and tool/model configuration to current GHCP expectations.
Changes:
- Bumps
OpenAIto 2.8.0 and updatesMicrosoft.Extensions.AI.OpenAIversion. - Makes
resourceNamenon-nullable forGetStructuredLogsAsync/GetTracesAsynctool methods. - Adds
gpt-5.4to the assistant’s default model fallback list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Aspire.Dashboard/Model/Assistant/AssistantChatViewModel.cs | Updates default model preference order to include gpt-5.4. |
| src/Aspire.Dashboard/Model/Assistant/AssistantChatDataContext.cs | Updates AI tool method signatures for resourceName (now required). |
| eng/Versions.props | Updates Microsoft.Extensions.AI.OpenAI version used by the repo. |
| Directory.Packages.props | Updates the OpenAI NuGet package version to 2.8.0. |
This was referenced Mar 19, 2026
IEvangelist
approved these changes
Mar 19, 2026
eerhardt
reviewed
Mar 19, 2026
| <!-- dotnet/extensions --> | ||
| <MicrosoftExtensionsAIVersion>10.2.0</MicrosoftExtensionsAIVersion> | ||
| <MicrosoftExtensionsAIOpenAIVersion>10.1.0-preview.1.25608.1</MicrosoftExtensionsAIOpenAIVersion> | ||
| <MicrosoftExtensionsAIOpenAIVersion>10.2.0-preview.1.26063.2</MicrosoftExtensionsAIOpenAIVersion> |
Member
There was a problem hiding this comment.
(this comment shouldn't block - just me asking) There are stable versions of this package now, should we be using them instead?
https://www.nuget.org/packages/Microsoft.Extensions.AI.OpenAI
Member
Author
There was a problem hiding this comment.
I kept it in sync with Microsoft.Extensions.AI.OpenAI. We're using 10.2.0 for it, so using 10.2.0 preview. Can stablize when we update packages again.
eerhardt
reviewed
Mar 19, 2026
src/Aspire.Dashboard/Model/Assistant/AssistantChatDataContext.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 19, 2026
src/Aspire.Dashboard/Model/Assistant/AssistantChatDataContext.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
eerhardt
approved these changes
Mar 19, 2026
adamint
approved these changes
Mar 19, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 53 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23301590151 |
joperezr
added
Servicing-approved
Member
|
Thanks a bunch for the quick turnaround on this @JamesNK ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix dashboard GitHub Copilot integration:
resourceNameparameter required (non-nullable) forGetStructuredLogsAsyncandGetTracesAsynctool methods inAssistantChatDataContextAssistantChatViewModelThe core fix is changing
resourceNameto be non-nullable. I believe the issue is caused by Microsoft.OpenApi being updated to a newer version, and a change in the newer version is to provide the parametertypeas an array instead of a string. Code in VS breaks on the unexpected JSON.Changing resourceName to be non-nullable means
typestays a string.I've tested 13.2 dashboard GHCP works with 18.4.
Fixes #15311
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: