Skip to content

Improve create-pr skill with cross-platform support and best practices#15748

Merged
JamesNK merged 2 commits intomainfrom
improve/create-pr-skill
Apr 1, 2026
Merged

Improve create-pr skill with cross-platform support and best practices#15748
JamesNK merged 2 commits intomainfrom
improve/create-pr-skill

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Apr 1, 2026

Description

Improve the create-pr AI skill to follow best practices and work cross-platform.

Changes:

  • Keyword-rich description for better agent discovery (includes trigger phrases like "create PR", "open PR", "submit PR")
  • Example requests section to help agent match user intent
  • Prerequisites section to check for gh CLI and auth before starting
  • Cross-platform commands with both bash and PowerShell syntax, plus explanation of differences (GH_PAGER=cat is bash-only; PowerShell needs $env:GH_PAGER)
  • GH_PAGER explanation so agents understand why it's needed
  • Temp file cleanup step after PR creation
  • Error handling table covering common failures (gh not found, auth issues, push rejected)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

- Add keyword-rich description for better agent discovery
- Add example requests, prerequisites, and error handling
- Show both bash and PowerShell commands with explanation
- Add GH_PAGER explanation and temp file cleanup step
Copilot AI review requested due to automatic review settings April 1, 2026 06:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15748

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15748"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the .github/skills/create-pr skill documentation to better guide agents in creating pull requests using the repo template, with clearer discovery keywords and cross-platform (bash/PowerShell) command guidance.

Changes:

  • Expands skill metadata and adds “Example requests” to improve intent matching/discovery.
  • Adds prerequisite checks (gh installed + authenticated) and a more structured step-by-step procedure.
  • Documents bash + PowerShell variants for gh pr create, adds GH_PAGER rationale, cleanup guidance, and an error-handling table.

Comment thread .github/skills/create-pr/SKILL.md Outdated
Comment thread .github/skills/create-pr/SKILL.md Outdated
- Standardize temp file name to 'pr-body.md' (remove 'e.g.')
- Move cleanup step after 'Handle existing PRs' so the temp file
  is available for gh pr edit
@JamesNK JamesNK merged commit 2307b2e into main Apr 1, 2026
5 checks passed
@JamesNK JamesNK deleted the improve/create-pr-skill branch April 1, 2026 07:04
@joperezr joperezr added this to the 13.3 milestone Apr 14, 2026
@aspire-repo-bot
Copy link
Copy Markdown
Contributor

No documentation PR is required for this change.

Reason: This PR improves an internal AI skill (create-pr) used by the development tooling. It contains no public API additions, new user-facing features, configuration changes, or behavioral changes that affect Aspire end-users. The change is internal infrastructure only, and the PR author also indicated docs updates are not needed.

Generated by PR Documentation Check · ● 85.3K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants