Implement health checks for Azure Key Vault CertificateClient and KeyClient#15966
Open
Formatted wants to merge 1 commit intomicrosoft:mainfrom
Open
Implement health checks for Azure Key Vault CertificateClient and KeyClient#15966Formatted wants to merge 1 commit intomicrosoft:mainfrom
Formatted wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Formatted
requested review from
eerhardt,
radical and
sebastienros
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15966Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15966" |
eerhardt
reviewed
Apr 8, 2026
| } | ||
|
|
||
| protected override void SetHealthCheck(AzureSecurityKeyVaultSettings options, bool enabled) | ||
| // Disable Key Vault health check tests until https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/issues/2279 is fixed |
Member
There was a problem hiding this comment.
I think it would be better if we fixed this issue in Xabaril/AspNetCore.Diagnostics.HealthChecks instead. And then used that library.
Author
There was a problem hiding this comment.
opened PR to add the dedicated packages. Will update this PR to use them once merged and published to NuGet.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CertificateClientandKeyClientregistrations hadGetHealthCheckEnabledhardcoded tofalseandCreateHealthCheckthrowingNotImplementedException, meaning health checks were silently disabled for these two Key Vault client types regardless of theDisableHealthCheckssetting.This PR adds
AzureKeyVaultCertificatesHealthCheckandAzureKeyVaultKeysHealthCheck— lightweightIHealthCheckimplementations that use the already-registered SDK clients to enumerate the first page of properties (one read-only API call), verifying vault connectivity. No new NuGet dependencies are introduced since no equivalent split packages exist inAspNetCore.Diagnostics.HealthChecksfor Certificates or Keys (only Secrets has one). The conformance testSetHealthCheckoverrides for both client types are also enabled.Fixes # (issue) — N/A, addressing existing
NotImplementedException/ hardcodedfalseChecklist
SetHealthCheckconformance tests enabled forCertificateClientConformanceTestsandKeyClientConformanceTests