Skip to content

Rename NameOutput to NameOutputReference in Aspire.Hosting.Azure.Network#16004

Merged
eerhardt merged 2 commits intomicrosoft:mainfrom
eerhardt:FixNameOutput
Apr 9, 2026
Merged

Rename NameOutput to NameOutputReference in Aspire.Hosting.Azure.Network#16004
eerhardt merged 2 commits intomicrosoft:mainfrom
eerhardt:FixNameOutput

Conversation

@eerhardt
Copy link
Copy Markdown
Member

@eerhardt eerhardt commented Apr 9, 2026

Description

Rename NameOutput properties to NameOutputReference across all Azure Network resource types in Aspire.Hosting.Azure.Network to be consistent with the naming convention used by all other Azure hosting integrations (e.g. CosmosDB, Redis, Storage, KeyVault, ServiceBus, etc.).

This is acceptable breaking change because this library has an Experimental attribute on it:

[assembly: Experimental("ASPIREAZURE003", UrlFormat = "https://aka.ms/dotnet/aspire/diagnostics#{0}")]

Updated files:

  • AzureNatGatewayResource.cs
  • AzureNetworkSecurityGroupResource.cs
  • AzurePrivateDnsZoneResource.cs
  • AzurePrivateEndpointResource.cs
  • AzurePrivateEndpointExtensions.cs
  • AzurePublicIPAddressResource.cs
  • AzureVirtualNetworkResource.cs

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Rename NameOutput properties to NameOutputReference across all Azure Network
resource types to be consistent with the naming convention used by other Azure
hosting integrations (e.g. CosmosDB, Redis, Storage, KeyVault, etc.).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 9, 2026 16:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16004

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16004"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the Azure Network hosting integration with the broader Aspire Azure hosting convention by renaming NameOutput properties to NameOutputReference across Azure Network resource types.

Changes:

  • Renames NameOutput to NameOutputReference on Azure Network resource types and updates internal usages accordingly.
  • Updates AzurePrivateEndpointExtensions to reference the renamed property.
  • Removes DisablePackageBaselineValidation from the Azure Network project.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/Aspire.Hosting.Azure.Network/AzureVirtualNetworkResource.cs Renames NameOutput to NameOutputReference and updates existing-resource wiring.
src/Aspire.Hosting.Azure.Network/AzurePublicIPAddressResource.cs Renames NameOutput to NameOutputReference and updates existing-resource wiring.
src/Aspire.Hosting.Azure.Network/AzurePrivateEndpointResource.cs Renames NameOutput to NameOutputReference and updates existing-resource wiring.
src/Aspire.Hosting.Azure.Network/AzurePrivateEndpointExtensions.cs Updates reference to DNS zone name output property.
src/Aspire.Hosting.Azure.Network/AzurePrivateDnsZoneResource.cs Renames NameOutput to NameOutputReference (internal type).
src/Aspire.Hosting.Azure.Network/AzureNetworkSecurityGroupResource.cs Renames NameOutput to NameOutputReference and updates existing-resource wiring.
src/Aspire.Hosting.Azure.Network/AzureNatGatewayResource.cs Renames NameOutput to NameOutputReference and updates existing-resource wiring.
src/Aspire.Hosting.Azure.Network/Aspire.Hosting.Azure.Network.csproj Re-enables package baseline validation by removing the disabling flag.

@eerhardt eerhardt merged commit 7f518a5 into microsoft:main Apr 9, 2026
524 of 527 checks passed
@eerhardt eerhardt deleted the FixNameOutput branch April 9, 2026 22:56
eerhardt added a commit to eerhardt/aspire that referenced this pull request Apr 10, 2026
The NameOutput property was renamed to NameOutputReference in microsoft#16004,
and the baseline version was bumped in microsoft#16008. Add CP0002 suppressions
for the removed NameOutput getters on the 5 affected network resources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eerhardt added a commit that referenced this pull request Apr 10, 2026
…#16022)

The NameOutput property was renamed to NameOutputReference in #16004,
and the baseline version was bumped in #16008. Add CP0002 suppressions
for the removed NameOutput getters on the 5 affected network resources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants