Handle describe --follow disconnects#16271
Merged
sebastienros merged 6 commits intomainfrom Apr 22, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sebastienros
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16271Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16271" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the resilience of aspire describe --follow by treating AppHost backchannel disconnects (e.g., AppHost stop/restart causing JSON-RPC disposal/connection loss) as a normal end-of-stream instead of an unexpected CLI failure, and adds a regression test for the disposed JSON-RPC scenario.
Changes:
- Catch and suppress expected backchannel disconnect exceptions during
describe --follow, returning success. - Add a regression test that simulates a disposed JSON-RPC backchannel during follow mode.
- Extend the test service setup helper to allow per-test backchannel customization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Cli/Commands/DescribeCommand.cs | Handles expected JSON-RPC/backchannel disconnect exceptions in follow mode and exits successfully. |
| tests/Aspire.Cli.Tests/Commands/DescribeCommandTests.cs | Adds a regression test covering the disposed backchannel case; enhances test wiring to customize the fake connection. |
JamesNK
reviewed
Apr 18, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Member
|
Do all the places that have
And the |
Contributor
Author
|
Same issue with logs only |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🎬 CLI E2E Test Recordings — 72 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24731002684 |
JamesNK
approved these changes
Apr 21, 2026
Contributor
|
No documentation PR is required for this change. This is a bug fix that improves error resilience in
|
This was referenced Apr 24, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle
aspire describe --followdisconnects gracefully when the AppHost stops or restarts.Add a regression test for the disposed JSON-RPC backchannel case.
Fixes #16270
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: