Move user secrets descriptions to checkbox inputs#16293
Merged
Conversation
- Skip rendering FluentInputLabel for boolean inputs in InteractionInputField since checkboxes already render their own label - Move user secrets link from SetParameterMessage to the 'Save to user secrets' checkbox description - Move user secrets info from DeleteParameterMessageWithUserSecrets to the 'Delete from user secrets' checkbox description - Add ParametersInputsRememberDescriptionConfigured and ParametersInputsDeleteDescription resource strings Fixes #16272
JamesNK
requested review from
adamint,
danegsta,
davidfowl,
karolz-ms and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16293Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16293" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the “Set Parameters”/delete parameter interaction strings and checkbox rendering so user-secrets help text lives with the checkbox (instead of duplicating dialog-level copy), and avoids rendering a redundant label above boolean (checkbox) inputs.
Changes:
- Skip rendering
FluentInputLabelforInputType.BooleaninInteractionInputFieldto remove duplicated checkbox labeling. - Add new localized resources for user-secrets checkbox descriptions and wire them into
ParameterProcessor(save/delete flows). - Update existing interaction messages to remove user-secrets copy from dialog-level text (and introduce new trans-units in localized XLFs).
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.zh-Hant.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Traditional Chinese). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.zh-Hans.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Simplified Chinese). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.tr.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Turkish). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.ru.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Russian). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.pt-BR.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Portuguese - Brazil). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.pl.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Polish). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.ko.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Korean). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.ja.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Japanese). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.it.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Italian). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.fr.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (French). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.es.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Spanish). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.de.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (German). |
| src/Aspire.Hosting/Resources/xlf/InteractionStrings.cs.xlf | Moves/remodels user-secrets copy into new checkbox-description strings (Czech). |
| src/Aspire.Hosting/Resources/InteractionStrings.resx | Adds new resource entries for configured save/delete descriptions; trims dialog-level messages. |
| src/Aspire.Hosting/Resources/InteractionStrings.Designer.cs | Regenerates strongly-typed resource accessors for new strings. |
| src/Aspire.Hosting/Orchestrator/ParameterProcessor.cs | Uses the new checkbox description strings and markdown for save/delete user-secrets checkboxes. |
| src/Aspire.Dashboard/Components/Controls/InteractionInputField.razor | Skips FluentInputLabel for boolean inputs to avoid duplicated checkbox labeling. |
Files not reviewed (1)
- src/Aspire.Hosting/Resources/InteractionStrings.Designer.cs: Language not supported
davidfowl
approved these changes
Apr 18, 2026
Member
Author
|
@davidfowl I added a small space: 
|
Contributor
|
🎬 CLI E2E Test Recordings — 72 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24598018667 |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Apr 18, 2026
This was referenced Apr 24, 2026
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move user secrets descriptions from dialog-level messages to the checkbox input descriptions, and skip rendering the redundant
FluentInputLabelfor boolean (checkbox) inputs since checkboxes already render their own label.Previously, the "Save to user secrets" and "Delete from user secrets" checkboxes displayed the same text as both the section title label above the checkbox and the checkbox's own label, which looked redundant. This change:
FluentInputLabelforInputType.Booleaninputs inInteractionInputField(the checkbox already has its own label)SetParameterMessageto a newParametersInputsRememberDescriptionConfigureddescription on the "Save to user secrets" checkboxDeleteParameterMessageWithUserSecretsto a newParametersInputsDeleteDescriptiondescription on the "Delete from user secrets" checkboxAfter:
Fixes #16272
@maddymontaquila
Checklist