Disable browser autocomplete on dashboard search and input fields#16297
Merged
Disable browser autocomplete on dashboard search and input fields#16297
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16297Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16297" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Aspire Dashboard’s search and input fields to reduce/avoid browser-provided autocomplete suggestions that can visually overlap the UI.
Changes:
- Adds
AutoComplete="off"to severalFluentSearchandFluentTextFieldinputs (e.g., traces, details panes, interactions dialog). - Adds
Name="..."to someFluentSearchcomponents to help browsers treat them as distinct fields.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Dashboard/Components/Pages/Traces.razor | Disables autocomplete on the traces page filter search. |
| src/Aspire.Dashboard/Components/Pages/TraceDetail.razor | Adds a Name to the spans filter search (desktop + mobile). |
| src/Aspire.Dashboard/Components/Pages/StructuredLogs.razor | Adds a Name to the structured logs filter search. |
| src/Aspire.Dashboard/Components/Pages/Resources.razor | Adds a Name to the resources filter search. |
| src/Aspire.Dashboard/Components/Dialogs/InteractionsInputDialog.razor | Disables autocomplete on text inputs in the interactions dialog. |
| src/Aspire.Dashboard/Components/Controls/StructuredLogDetails.razor | Disables autocomplete on the details-pane filter search. |
| src/Aspire.Dashboard/Components/Controls/SpanDetails.razor | Disables autocomplete on the span details filter search. |
| src/Aspire.Dashboard/Components/Controls/ResourceDetails.razor | Disables autocomplete on the resource details filter search. |
Comments suppressed due to low confidence (2)
src/Aspire.Dashboard/Components/Pages/TraceDetail.razor:53
- PR title/description says browser autocomplete is being disabled on dashboard search fields, but this FluentSearch sets a Name without setting AutoComplete="off". If the goal is to prevent browser-suggested entries from overlapping the UI, consider adding AutoComplete="off" here as well (or update the PR description/title to match the intended behavior).
<FluentSearch @bind-Value="_filter"
@bind-Value:after="HandleAfterFilterBindAsync"
Name="spans-search"
Immediate="true"
ImmediateDelay="@FluentUIExtensions.InputDelay"
Placeholder="@ControlStringsLoc[nameof(ControlsStrings.FilterPlaceholder)]"
title="@Loc[nameof(Dashboard.Resources.Traces.TracesNameFilter)]" />
src/Aspire.Dashboard/Components/Pages/TraceDetail.razor:79
- Same as above for the non-desktop toolbar: Name is set but AutoComplete="off" is not. If autocomplete is meant to be disabled to avoid UI overlap, add AutoComplete="off" here too (or update PR description/title accordingly).
<FluentSearch @bind-Value="_filter"
@bind-Value:after="HandleAfterFilterBindAsync"
Name="spans-search"
Immediate="true"
ImmediateDelay="@FluentUIExtensions.InputDelay"
Placeholder="@ControlStringsLoc[nameof(ControlsStrings.FilterPlaceholder)]"
title="@Loc[nameof(Dashboard.Resources.Traces.TracesNameFilter)]"/>
JamesNK
commented
Apr 18, 2026
davidfowl
approved these changes
Apr 18, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 72 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24598705522 |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Apr 18, 2026
This was referenced Apr 24, 2026
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't combine autocomplete with autofocus.
Changes:
AutoComplete="off"toFluentSearchcomponents inResourceDetails,SpanDetails,StructuredLogDetails,Traces, andInteractionsInputDialogNameattributes toFluentSearchcomponents inResources,StructuredLogs, andTraceDetailpages to give them unique identities and further discourage autocompleteChecklist