Update Spectre.Console to 0.55.2 and simplify EmojiWidth#16349
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16349Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16349" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s Spectre.Console dependency to 0.55.2 and removes now-unnecessary custom emoji-width logic, relying on Spectre’s built-in measurement fixes.
Changes:
- Bump
Spectre.Consolefrom0.55.0to0.55.2. - Simplify
EmojiWidth.GetCellWidthby delegating directly to Spectre measurement (removing the Unicode lookup/rune logic). - Update emoji width tests to enumerate
KnownEmojisvia reflection, automatically covering newly-added emojis.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Cli.Tests/Utils/EmojiWidthTests.cs | Switches test data source to reflect over KnownEmojis and validates measured widths for all known emoji names. |
| src/Aspire.Cli/Utils/EmojiWidth.cs | Removes the manual Emoji_Presentation workaround and uses Spectre.Console’s measurement directly. |
| Directory.Packages.props | Updates the central package version for Spectre.Console to 0.55.2. |
mitchdenny
approved these changes
Apr 21, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 72 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24698653461 |
Contributor
|
No documentation update is required for this PR. This change is a dependency version bump (Spectre.Console 0.55.0 → 0.55.2) combined with an internal simplification of
|
This was referenced Apr 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Spectre.Console from 0.55.0 to 0.55.2.
Spectre.Console 0.55.2 includes fixes for emoji width measurement, so the manual
HasDefaultEmojiPresentationworkaround inEmojiWidth.csis no longer needed. This PR:Spectre.Consoleto 0.55.2 inDirectory.Packages.propsEmojiWidth.csby removing theHasDefaultEmojiPresentationlookup table and rune-checking logic, delegating directly to Spectre's measurementEmojiWidthTests.csto use reflection overKnownEmojisinstead of hardcoded[InlineData]entries, so new emojis are automatically coveredChecklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: