Publish native Aspire CLI tool packages by radical · Pull Request #16570 · microsoft/aspire

radical · 2026-04-29T19:41:47Z

Description

Publishes the NativeAOT Aspire CLI dotnet tool packages produced by the native build jobs.

Fixes #16563

Changes:

Download native Aspire.Cli*.nupkg artifacts in the internal Azure Pipelines build and stage one package per filename into artifacts/packages/$(_BuildConfig)/Shipping.
Validate RID-specific Aspire.Cli.<rid> packages in eng/Publishing.props using the same _ExpectedCliRids source already used for native aspire-cli-* archives.
Add the staged Aspire.Cli*.nupkg packages to ItemsToPushToBlobFeed as shipping package-feed items.

Validation:

xmllint --noout eng/Publishing.props
YAML parse check for eng/pipelines/azure-pipelines.yml and eng/pipelines/azure-pipelines-unofficial.yml
git diff --check
./build.sh --build /p:SkipNativeBuild=true
Internal AzDO build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2963540

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire.dev issue:
    - New issue
- No

github-actions · 2026-04-29T19:46:36Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16570

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16570"

github-actions · 2026-04-29T20:18:35Z

Re-running the failed jobs in the CI workflow for this pull request because 2 jobs were identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Tests / Cli.EndToEnd-LocalConfigMigrationTests / Cli.EndToEnd-LocalConfigMigrationTests (ubuntu-latest) - Failed step 'Run nuget dependent tests (Linux/macOS)' will be retried because the job log matched a configurable test-retry pattern: MCR registry rate limiting (HTTP 403)
Tests / Microsoft.EntityFrameworkCore.SqlServer / Microsoft.EntityFrameworkCore.SqlServer (ubuntu-latest) - Test execution failure will be retried because 94 failed test(s) matched transient test failure patterns (MCR registry rate limiting (HTTP 403), MCR container pull denied (rate limiting)).

Matched test failure patterns (50 tests)

Aspire.Cli.EndToEnd.Tests.LocalConfigMigrationTests.LegacySettingsMigration_AdjustsRelativeAppHostPath — MCR registry rate limiting (HTTP 403)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.EnrichSqlServerTests.ShouldThrowIfDbContextIsNotRegistered — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.EnrichSqlServerTests.ShouldNotThrowIfDbContextIsRegistered — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.ConformanceTests.DbContextPoolingRegistersIDbContextPool — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.ConformanceTests.DbContextCanBeAlwaysResolved — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.ConformanceTests_TypeSpecificConfig.DbContextPoolingRegistersIDbContextPool — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.ConformanceTests_TypeSpecificConfig.DbContextCanBeAlwaysResolved — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.EnrichSqlServerTests.EnrichCanConfigureDbContextOptions — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.EnrichSqlServerTests.EnrichWithConflictingCommandTimeoutThrows — MCR container pull denied (rate limiting)
Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.ConformanceTests.TracingEnablesTheRightActivitySource — MCR container pull denied (rate limiting)
...and 40 more

Download RID-specific Aspire.Cli tool packages from native build artifacts and stage them in the shipping packages directory so publishing can include them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Compare discovered CLI archives and RID-specific tool packages against the expected clipack RIDs, require exactly one pointer package, and summarize publish output without listing every NuGet package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR updates Aspire’s internal publishing pipeline to ensure the NativeAOT Aspire CLI dotnet tool NuGet packages (Aspire.Cli*.nupkg) produced by the native build jobs are staged and published, addressing missing Aspire.Cli packages in the feed.

Changes:

Download Aspire.Cli*.nupkg artifacts from native build outputs and stage a single package per filename into artifacts/packages/$(_BuildConfig)/Shipping.
Add validation in eng/Publishing.props to ensure RID-specific Aspire.Cli.<rid> packages exist for every expected CLI RID (using the same RID source as native archives).
Include staged Aspire.Cli*.nupkg packages in publishing inputs (ItemsToPushToBlobFeed) and add logging to summarize publish items.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
eng/Publishing.props	Validates expected CLI RIDs across both native archives and RID-specific tool packages; adds CLI tool nupkgs to publishing items and logs publish inputs.
eng/pipelines/azure-pipelines.yml	Downloads native `Aspire.Cli*.nupkg` artifacts and stages deduped copies into the Shipping packages folder for publish.
eng/pipelines/azure-pipelines-unofficial.yml	Mirrors the official pipeline changes to stage native CLI tool nupkgs for unofficial runs.

radical · 2026-04-30T18:32:29Z

/backport to release/13.3

github-actions · 2026-04-30T18:32:43Z

Started backporting to release/13.3 (link to workflow run)

eerhardt · 2026-04-30T19:34:39Z

+                    throw "No native CLI tool packages were downloaded to $downloadRoot."
+                  }
+
+                  foreach ($packageGroup in $packages | Group-Object Name) {


How is this possible? They were all downloaded to the same folder - how could they have the same name?

It creates the relative paths from the archive. I'll make this whole thing more robust.

eerhardt · 2026-04-30T19:35:20Z

+                      Write-Host "Using $($package.FullName) for duplicate package name $($packageGroup.Name)."
+                    }
+
+                    Copy-Item -LiteralPath $package.FullName -Destination (Join-Path $shippingDir $package.Name) -Force


Why not just download them directly to this folder in the first place?

eerhardt · 2026-04-30T19:38:16Z

+
+  </Target>
+
+  <Target Name="_LogPublishItemsToPush" AfterTargets="_PublishBlobItems">


Do we need this? Why doesn't the publish have this log?

It's there but you have kinda go and parse it from messy output. This gives a quick overview.

radical · 2026-04-30T22:20:52Z

@eerhardt I'll tighten up the script in a follow up.

radical force-pushed the fix-publishing-dotnet-tool branch from 1138718 to 144e05b Compare April 29, 2026 22:01

radical and others added 2 commits April 29, 2026 20:44

fix(publishing): stage native CLI tool packages

721176c

Download RID-specific Aspire.Cli tool packages from native build artifacts and stage them in the shipping packages directory so publishing can include them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

radical force-pushed the fix-publishing-dotnet-tool branch from 08345bb to cc05691 Compare April 30, 2026 00:45

radical marked this pull request as ready for review April 30, 2026 02:24

Copilot AI review requested due to automatic review settings April 30, 2026 02:24

Copilot started reviewing on behalf of radical April 30, 2026 02:24 View session

radical requested review from adamint, eerhardt and joperezr April 30, 2026 02:24

Copilot AI reviewed Apr 30, 2026

View reviewed changes

github-actions Bot mentioned this pull request Apr 30, 2026

[repo-pulse] 📊 Repo Pulse — Daily Activity Dashboard #16404

Open

aspire-repo-bot Bot mentioned this pull request Apr 30, 2026

[release/13.3] Publish native Aspire CLI tool packages #16611

Merged

eerhardt reviewed Apr 30, 2026

View reviewed changes

eerhardt approved these changes Apr 30, 2026

View reviewed changes

radical merged commit cc7d4db into microsoft:main Apr 30, 2026
564 of 567 checks passed

microsoft-github-policy-service Bot added this to the 13.4 milestone Apr 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish native Aspire CLI tool packages#16570

Publish native Aspire CLI tool packages#16570
radical merged 2 commits intomicrosoft:mainfrom
radical:fix-publishing-dotnet-tool

radical commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

radical commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

eerhardt Apr 30, 2026

Uh oh!

radical Apr 30, 2026

Uh oh!

eerhardt Apr 30, 2026

Uh oh!

eerhardt Apr 30, 2026

Uh oh!

radical Apr 30, 2026

Uh oh!

radical commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		</Target>

		<Target Name="_LogPublishItemsToPush" AfterTargets="_PublishBlobItems">

Conversation

radical commented Apr 29, 2026

Description

Checklist

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

radical commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

eerhardt Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

radical Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

eerhardt Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

eerhardt Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

radical Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

radical commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 29, 2026 •

edited

Loading