[release/13.3] Fix Python starter TypeScript health check build#16647
Merged
joperezr merged 6 commits intorelease/13.3from May 1, 2026
Merged
[release/13.3] Fix Python starter TypeScript health check build#16647joperezr merged 6 commits intorelease/13.3from
joperezr merged 6 commits intorelease/13.3from
Conversation
Update the Python starter TypeScript AppHost to use the supported withHttpHealthCheck options object and align its root build script with AppHost-only type checking. Add E2E coverage that verifies the generated starter builds successfully. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the Python React template E2E build verification to use the existing fail-fast command helper so npm build failures are surfaced immediately. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aspire-repo-bot
Bot
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16647Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16647" |
eerhardt
reviewed
May 1, 2026
Member
There was a problem hiding this comment.
This is outside your change - but why is this file named tsconfig.json when the TypeScript template names it tsconfig.apphost.json?
eerhardt
reviewed
May 1, 2026
| languageOptions: { | ||
| parserOptions: { | ||
| projectService: true, | ||
| project: './tsconfig.apphost.json', |
Member
There was a problem hiding this comment.
This is different than the python template. Is that intentional?
Member
There was a problem hiding this comment.
It feels like python and ts should drop the exact same apphost files, unless there is a specific reason not to.
Contributor
There was a problem hiding this comment.
Instead of adapting I should have aligned the two, doing it now, but on the main branch first
Contributor
There was a problem hiding this comment.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Backports fixes to the release/13.3 branch to ensure TypeScript AppHost projects generated by templates (notably the Python starter) build and lint correctly with the current TypeScript SDK and ESLint configuration.
Changes:
- Updates TypeScript AppHost scaffolding and template ESLint configuration to explicitly target
tsconfig.apphost.json(avoids traversing unrelated TS sources). - Adds “wrapper” root npm scripts (
build,lint,dev, etc.) for greenfield TypeScript AppHost projects to makenpm run build/npm run lintbehave as expected. - Strengthens CLI E2E coverage by verifying
npm run buildsucceeds for TypeScript-based AppHost templates, and fixes the Python starter’s TypeScript health check callsite.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/TypeScriptLanguageSupportTests.cs | Updates expectations for newly scaffolded package.json scripts and validates ESLint config targets tsconfig.apphost.json. |
| tests/Aspire.Cli.EndToEnd.Tests/TypeScriptStarterTemplateTests.cs | Adds npm run build verification for the TypeScript starter template before starting the app. |
| tests/Aspire.Cli.EndToEnd.Tests/TypeScriptEmptyAppHostTemplateTests.cs | Adds npm run build verification for the empty TypeScript AppHost template. |
| tests/Aspire.Cli.EndToEnd.Tests/PythonReactTemplateTests.cs | Adds npm run build verification for the Python/React (TypeScript AppHost) template. |
| src/Aspire.Hosting.CodeGeneration.TypeScript/TypeScriptLanguageSupport.cs | Switches ESLint parser options to a dedicated AppHost tsconfig and adds greenfield-friendly root npm script aliases. |
| src/Aspire.Cli/Templating/Templates/ts-starter/eslint.config.mjs | Aligns ESLint config to lint using tsconfig.apphost.json and an explicit root dir. |
| src/Aspire.Cli/Templating/Templates/py-starter/tsconfig.json | Removes the old root tsconfig.json that no longer matches the intended AppHost compilation flow. |
| src/Aspire.Cli/Templating/Templates/py-starter/tsconfig.apphost.json | Adds a dedicated AppHost tsconfig matching the CLI scaffolding approach. |
| src/Aspire.Cli/Templating/Templates/py-starter/package.json | Renames AppHost scripts under aspire:* and adds root wrappers so npm run build/npm run lint work. |
| src/Aspire.Cli/Templating/Templates/py-starter/eslint.config.mjs | Aligns ESLint config to lint using tsconfig.apphost.json and an explicit root dir. |
| src/Aspire.Cli/Templating/Templates/py-starter/apphost.ts | Updates to the supported withHttpHealthCheck({ path }) call pattern. |
joperezr
added
Servicing-approved
Contributor
|
🎬 CLI E2E Test Recordings — 66 recordings uploaded (commit View all recordings
📹 Recordings uploaded automatically from CI run #25226700754 |
joperezr
approved these changes
May 1, 2026
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Change is minimal, fixing real customer-facing bugs. Looks good to go.
Contributor
Author
|
No documentation PR is required for this change. This is a bug fix backport that corrects template build issues (broken TypeScript health check method call and ESLint config) in the Python starter and TypeScript AppHost templates. It restores expected behavior without introducing new APIs, features, or configuration options that would require documentation updates.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16625 to release/13.3
/cc @sebastienros
Customer Impact
Python starter template doesn't build (uses old health check method).
TypeScript empty AppHost template fails linting when called explicitly.
Testing
Added build verification for all typescript apphost based templates
Risk
Low
Regression?
From previous release