Conversation
Addressing feedback from #16602 Rename JS experimental ID, refactor AKS/EF resource APIs Renames ASPIREEXTENSION001 to ASPIREJAVASCRIPT001 for JavaScript APIs, resources, and tests. Refactors AKS-related code to Aspire.Hosting.Azure.Kubernetes, makes AksSkuTier internal, and defaults AKS SKU tier to Free. Renames EFMigrationResource.ContextTypeName to DbContextTypeName throughout. Adds missing using directives, Experimental attributes, and AspireValue metadata. Updates tests and samples for new names and diagnostics.
eerhardt
requested review from
JamesNK,
danegsta,
davidfowl,
karolz-ms and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16673Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16673" |
Member
Author
|
/backport to release/13.3 |
Contributor
|
Started backporting to |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses prior API review feedback by standardizing experimental diagnostic IDs for JavaScript hosting APIs, refactoring/relocating AKS-related Azure Kubernetes code, and renaming an EF Core migrations resource property for clarity.
Changes:
- Renames JavaScript experimental diagnostic usage to
ASPIREJAVASCRIPT001across relevant APIs, tests, and samples; adds missing[Experimental]attributes on JavaScript types/methods. - Refactors Azure Kubernetes (AKS) code into
Aspire.Hosting.Azure.Kubernetes, removes the AKS SKU tier surface area, and hard-codes the provisioned tier to Free. - Renames
EFMigrationResource.ContextTypeNametoDbContextTypeNameand updates EF migrations code/tests accordingly (including movingEFMigrationResourceto a new namespace).
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.JavaScript.Tests/NodeJsPublicApiTests.cs | Updates pragma suppression to the new JavaScript experimental diagnostic ID. |
| tests/Aspire.Hosting.JavaScript.Tests/AddViteAppTests.cs | Updates pragma suppression to ASPIREJAVASCRIPT001 for JavaScript publish-related tests. |
| tests/Aspire.Hosting.JavaScript.Tests/AddNodeAppTests.cs | Adds ASPIREJAVASCRIPT001 suppression alongside existing experimental suppression for debugging-related tests. |
| tests/Aspire.Hosting.JavaScript.Tests/AddJavaScriptAppTests.cs | Updates pragma suppression to ASPIREJAVASCRIPT001. |
| tests/Aspire.Hosting.EntityFrameworkCore.Tests/EFMigrationConfigurationTests.cs | Updates assertions to use DbContextTypeName. |
| tests/Aspire.Hosting.EntityFrameworkCore.Tests/EFMigrationCommandsTests.cs | Updates assertions to use DbContextTypeName. |
| tests/Aspire.Hosting.EntityFrameworkCore.Tests/AddEFMigrationsTests.cs | Updates assertions to use DbContextTypeName. |
| tests/Aspire.Hosting.Azure.Kubernetes.Tests/AzureKubernetesEnvironmentExtensionsTests.cs | Removes assertions tied to the removed SkuTier surface. |
| src/Aspire.Hosting/Pipelines/WellKnownPipelineSteps.cs | Adds missing AspireValue metadata attributes for pipeline step constants. |
| src/Aspire.Hosting/Dcp/DcpExecutor.cs | Removes obsolete ASPIREEXTENSION001 suppression. |
| src/Aspire.Hosting/Dcp/ContainerCreator.cs | Removes obsolete ASPIREEXTENSION001 suppression. |
| src/Aspire.Hosting.JavaScript/PublishAsStaticWebsiteOptions.cs | Marks options type as experimental under ASPIREJAVASCRIPT001. |
| src/Aspire.Hosting.JavaScript/NextJsAppResource.cs | Marks Next.js resource type as experimental under ASPIREJAVASCRIPT001. |
| src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs | Updates/expands experimental annotations for JavaScript publish APIs and Next.js APIs. |
| src/Aspire.Hosting.EntityFrameworkCore/EFResourceBuilderExtensions.cs | Switches to DbContextTypeName and updates executor calls accordingly. |
| src/Aspire.Hosting.EntityFrameworkCore/EFMigrationResourceBuilderExtensions.cs | Adds the new EF Core namespace import needed after moving EFMigrationResource. |
| src/Aspire.Hosting.EntityFrameworkCore/EFMigrationResource.cs | Renames property to DbContextTypeName and changes the type’s namespace. |
| src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesIngressExtensions.cs | Updates using to the new Azure Kubernetes namespace. |
| src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentResource.cs | Moves resource into Aspire.Hosting.Azure.Kubernetes and removes SkuTier property. |
| src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentResource.AksPipeline.cs | Moves pipeline implementation into Aspire.Hosting.Azure.Kubernetes. |
| src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentExtensions.cs | Hard-codes AKS managed cluster SKU tier to Free in provisioning. |
| src/Aspire.Hosting.Azure.Kubernetes/AksSkuTier.cs | Makes AksSkuTier internal. |
| playground/AspireWithNode/AspireWithNode.AppHost/AppHost.cs | Removes ASPIREEXTENSION001 suppression from the sample AppHost. |
| playground/AspireWithJavaScript/AspireJavaScript.AppHost/AppHost.cs | Updates sample pragmas to use ASPIREJAVASCRIPT001 for static website publish demo. |
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs:439
- Marking this private helper method as
[Experimental("ASPIREJAVASCRIPT001")]will raise ASPIREJAVASCRIPT001 warnings at its internal call sites (including within this file), and there is no suppression for ASPIREJAVASCRIPT001 here. Since the method is private and not part of the public surface, consider removing the attribute (keep it on the public entry points) or add appropriate local suppression where it’s invoked.
[Experimental("ASPIREJAVASCRIPT001", UrlFormat = "https://aka.ms/aspire/diagnostics/{0}")]
private static IResourceBuilder<TResource> PublishAsStaticWebsiteCore<TResource>(
IResourceBuilder<TResource> builder,
string? apiPath,
IResourceBuilder<IResourceWithServiceDiscovery>? apiTarget,
PublishAsStaticWebsiteOptions options)
Member
Author
|
/backport to release/13.3 |
Contributor
|
Started backporting to |
AndriySvyryd
approved these changes
May 1, 2026
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
davidfowl
approved these changes
May 1, 2026
Adding [AspireValue("WellKnownPipelineSteps")] to BeforeStart and
CheckContainerRuntime causes the language code generators to emit them
in the WellKnownPipelineSteps exported value catalog. Update the
TwoPassScanningGeneratedAspire snapshots for Go, Java, Python, Rust, and
TypeScript to include the two new entries.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 3 jobs were identified as retry-safe transient failures in the CI run attempt.
Matched test failure patterns (2 tests)
|
Contributor
|
🎬 CLI E2E Test Recordings — 76 recordings uploaded (commit View all recordings
📹 Recordings uploaded automatically from CI run #25235507522 |
Contributor
|
Warning The 📝 Documentation update drafted A draft docs PR has been opened on Target branch: Summary of documentation changes:
The draft PR needs human review before merging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing feedback from #16602
Rename JS experimental ID, refactor AKS/EF resource APIs
Renames ASPIREEXTENSION001 to ASPIREJAVASCRIPT001 for JavaScript APIs, resources, and tests. Refactors AKS-related code to Aspire.Hosting.Azure.Kubernetes, makes AksSkuTier internal, and defaults AKS SKU tier to Free. Renames EFMigrationResource.ContextTypeName to DbContextTypeName throughout. Adds missing using directives, Experimental attributes, and AspireValue metadata. Updates tests and samples for new names and diagnostics.