Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16718Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16718" |
Contributor
There was a problem hiding this comment.
Pull request overview
Polishes Aspire CLI user-facing output around init/new by adjusting markdown line termination, adding spacing before the optional agent-init handoff, and re-echoing the selected AppHost language so the prompt context remains visible after selection.
Changes:
- Updates markdown rendering in
ConsoleInteractionServiceto avoid appending an extra newline when markdown is rendered as SpectreRows. - Adds explicit blank lines before chaining from
newandinitinto the optional agent-init flow. - Reprints the selected AppHost language in
LanguageServiceafter the selection prompt clears.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Aspire.Cli/Projects/LanguageService.cs |
Adjusts the AppHost language prompt output and echoes the chosen language after selection. |
src/Aspire.Cli/Interaction/ConsoleInteractionService.cs |
Changes markdown output termination behavior for Rows renderables. |
src/Aspire.Cli/Commands/NewCommand.cs |
Inserts spacing before the post-template agent-init handoff in aspire new. |
src/Aspire.Cli/Commands/InitCommand.cs |
Inserts spacing before the post-init agent-init handoff in aspire init. |
Comments suppressed due to low confidence (1)
src/Aspire.Cli/Commands/InitCommand.cs:166
- This has the same unconditional-spacing problem as
aspire new: when--suppress-agent-initis supplied, the confirmation never renders, but we still emit this empty line. That leavesaspire initwith a trailing blank line on successful runs where agent init was intentionally skipped.
InteractionService.DisplayEmptyLine();
// Step 4: Chain to aspire agent init for MCP server + skill configuration.
// This prompt lets users choose which skills to install — including aspireify.
var workspaceRoot = solutionFile?.Directory ?? workingDirectory;
var agentInitBinding = PromptBinding.CreateInvertedBoolConfirm(parseResult, NewCommand.s_suppressAgentInitOption, defaultValue: true);
var agentInitResult = await _agentInitCommand.PromptAndChainAsync(InteractionService, ExitCodeConstants.Success, workspaceRoot, agentInitBinding, cancellationToken);
davidfowl
approved these changes
May 4, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 76 recordings uploaded (commit View all recordings
📹 Recordings uploaded automatically from CI run #25307545236 |
Contributor
|
No documentation PR is required for this change. This PR improves CLI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves CLI output spacing in the init/new flows before chaining into agent init, avoids an extra trailing newline when markdown renders as Spectre rows, and restores the selected AppHost language prompt text after selection so users keep context as the cleared prompt advances.
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: