Render AppHost summary flush in extension host#16801
Closed
adamint wants to merge 1 commit into
Closed
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16801Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16801" |
Member
Author
|
Superseded by #16795, which now includes this focused slice. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the aspire run AppHost startup summary rendering to avoid terminal-centric formatting (left padding, right-aligned labels, blank separator rows) when running under the VS Code extension host.
Changes:
- Introduces a shared
LabelMarkup(...)helper to switch between right-aligned labels (terminal) and non-aligned labels (extension host). - Removes blank separator rows and outer padding when
isExtensionHostis true, while preserving the existing terminal layout.
Comment on lines
514
to
516
| var longestLabelLength = labels.Max(s => s.Length) + 1; // +1 for colon | ||
|
|
||
| grid.Columns[0].Width = longestLabelLength; |
Comment on lines
+518
to
+522
| // In the extension's debug console, right-aligned labels and the surrounding padding | ||
| // render as visible left indentation, and the empty separator rows show up as blank | ||
| // lines that just push real content further down. Use a flush, single-spaced layout | ||
| // for the extension and keep the spaced-out look only for direct terminal output. | ||
| IRenderable LabelMarkup(string label) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the AppHost startup summary layout when
aspire runis hosted by the VS Code extension.The terminal-oriented summary uses left padding, right-aligned labels, and blank separator rows for readability. In the extension debug console those choices show up as unwanted indentation and extra blank lines. This change keeps the existing terminal layout unchanged, but renders the extension-host summary flush and single-spaced:
Validation:
./dotnet.sh build src/Aspire.Cli/Aspire.Cli.csproj /p:SkipNativeBuild=trueFixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: