Require --yes with --non-interactive for destroy cmd#16805
Merged
Conversation
Added validation to enforce --yes when --non-interactive is used with the destroy command, returning a localized error if omitted. Introduced a new NonInteractiveRequiresYes resource and updated all localization files. Expanded DestroyCommandTests to cover new validation, multiple CLI permutations, and error scenarios for failed destroy activities. Fix #16623
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16805Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16805" |
Member
Author
|
/backport to release/13.3 |
Contributor
|
Started backporting to |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Aspire CLI destroy command to fail fast when --non-interactive is used without explicit confirmation via --yes, and adds coverage to ensure destroy pipeline failures propagate a non-zero exit code.
Changes:
- Added a
DestroyCommandvalidator requiring--yeswhen--non-interactiveis specified. - Introduced a new localized resource string (
NonInteractiveRequiresYes) and propagated it to allDestroyCommandStringslocalization files. - Expanded
DestroyCommandTeststo cover argument permutations and non-zero exit code behavior when destroy activities report failure.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Cli.Tests/Commands/DestroyCommandTests.cs | Adds fail-fast validation tests for --non-interactive without --yes, plus a test ensuring activity-reported failures return a non-zero exit code. |
| src/Aspire.Cli/Commands/DestroyCommand.cs | Adds a command validator enforcing --yes when running destroy in non-interactive mode. |
| src/Aspire.Cli/Resources/DestroyCommandStrings.resx | Adds the NonInteractiveRequiresYes localized string. |
| src/Aspire.Cli/Resources/DestroyCommandStrings.Designer.cs | Regenerates strongly-typed accessor for NonInteractiveRequiresYes. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.cs.xlf | Adds NonInteractiveRequiresYes entry for Czech localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.de.xlf | Adds NonInteractiveRequiresYes entry for German localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.es.xlf | Adds NonInteractiveRequiresYes entry for Spanish localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.fr.xlf | Adds NonInteractiveRequiresYes entry for French localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.it.xlf | Adds NonInteractiveRequiresYes entry for Italian localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.ja.xlf | Adds NonInteractiveRequiresYes entry for Japanese localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.ko.xlf | Adds NonInteractiveRequiresYes entry for Korean localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.pl.xlf | Adds NonInteractiveRequiresYes entry for Polish localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.pt-BR.xlf | Adds NonInteractiveRequiresYes entry for Portuguese (Brazil) localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.ru.xlf | Adds NonInteractiveRequiresYes entry for Russian localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.tr.xlf | Adds NonInteractiveRequiresYes entry for Turkish localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.zh-Hans.xlf | Adds NonInteractiveRequiresYes entry for Simplified Chinese localization. |
| src/Aspire.Cli/Resources/xlf/DestroyCommandStrings.zh-Hant.xlf | Adds NonInteractiveRequiresYes entry for Traditional Chinese localization. |
Files not reviewed (1)
- src/Aspire.Cli/Resources/DestroyCommandStrings.Designer.cs: Language not supported
Member
Author
|
/deployment-tests |
Contributor
|
🎬 CLI E2E Test Recordings — 76 recordings uploaded (commit View all recordings
📹 Recordings uploaded automatically from CI run #25406378054 |
davidfowl
approved these changes
May 6, 2026
Contributor
|
No documentation PR is required for this change. Reason: This PR adds a validation that requires
|
nellshamrell
pushed a commit
to nellshamrell/aspire
that referenced
this pull request
May 18, 2026
Added validation to enforce --yes when --non-interactive is used with the destroy command, returning a localized error if omitted. Introduced a new NonInteractiveRequiresYes resource and updated all localization files. Expanded DestroyCommandTests to cover new validation, multiple CLI permutations, and error scenarios for failed destroy activities. Fix microsoft#16623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation to enforce --yes when --non-interactive is used with the destroy command, returning a localized error if omitted. Introduced a new NonInteractiveRequiresYes resource and updated all localization files. Expanded DestroyCommandTests to cover new validation, multiple CLI permutations, and error scenarios for failed destroy activities.
Fix #16623
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist