Defer YARP resource endpoint resolution#16834
Merged
danegsta merged 1 commit intomicrosoft:mainfrom May 6, 2026
Merged
Conversation
Resolve YARP cluster targets from resource endpoints when generating environment configuration so late endpoint scheme changes, such as Uvicorn's HTTPS upgrade, are reflected in the reverse proxy destination. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16834Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16834" |
karolz-ms
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Defer YARP cluster target resolution for resource, endpoint, and external service destinations until environment configuration is generated. This ensures resource endpoint scheme changes made late in AppHost startup, such as
AddUvicornAppautomatically upgrading its primary endpoint to HTTPS when a developer certificate is available, are reflected in YARP's generated reverse proxy destinations.Resource targets now resolve through endpoint-aware logic consistent with explicit endpoint targets: scheme-named endpoints resolve as
scheme://resource, while named endpoints resolve with the DNS-SD named endpoint form such ashttp://_api.resource.Added regression coverage for late endpoint scheme updates and named endpoint resource resolution.
Fixes #16831
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: