Materialize Endpoints set in HostResourceWithEndpoints#17091
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a concurrent-modification crash in ContainerCreator.CreateContainerNetworkServicesForHostResource (issue #17083) by materializing the EndpointAnnotation enumerable captured in HostResourceWithEndpoints at construction time, so later enumerations don't re-read the (potentially mutating) resource.Annotations collection.
Changes:
- Materialize the LINQ-filtered endpoints to an array via
ToArray()before storing. - Replace
Any()check withLength > 0on the materialized array.
Contributor
|
Are we backporting ths @karolz-ms ? |
Contributor
Author
yep |
Contributor
Author
|
/backport to release/13.3 |
Contributor
|
Are there anymore spots where we may have concurrency issues? |
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17091Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17091" |
Contributor
|
Started backporting to |
Contributor
Author
Can't think of anything else at this point... |
karolz-ms
force-pushed
the
dev/karolz/host-resource-with-endpoints
branch
from
9fbfd0c to
59f3b15
Compare
danegsta
approved these changes
May 14, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 82 recordings uploaded (commit View all recordings
📹 Recordings uploaded automatically from CI run #25882088799 |
davidfowl
approved these changes
May 14, 2026
Contributor
|
✅ No documentation update needed. docs_optional → No signals triggered ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents #17083
Checklist
<remarks />and<code />elements on your triple slash comments?