Skip to content

[release/13.3] Skip log publish for WinGet/Homebrew installer jobs#17134

Merged
davidfowl merged 1 commit into
release/13.3from
backport/pr-16865-to-release/13.3
May 20, 2026
Merged

[release/13.3] Skip log publish for WinGet/Homebrew installer jobs#17134
davidfowl merged 1 commit into
release/13.3from
backport/pr-16865-to-release/13.3

Conversation

@aspire-repo-bot
Copy link
Copy Markdown
Contributor

Backport of #16865 to release/13.3

/cc @radical

Customer Impact

Testing

Risk

Regression?

These jobs only download already-built CLI archives and prepare
WinGet manifests / Homebrew casks; they never run the repo build,
so artifacts/log/$(_BuildConfig) is never produced. With
enablePublishBuildArtifacts: true, the Arcade 1ES job template
injects a Publish Logs pipelineArtifact output whose targetPath
points at that empty/missing directory. 1ES path validation on
that output fails the job (continueOnError on the CopyFiles step
doesn't help because the failure is on the 1ES publish output
itself).

Set enablePublishBuildArtifacts: false on the WinGet/Homebrew
installer stage in both the internal (azure-pipelines.yml) and
unofficial (azure-pipelines-unofficial.yml) pipelines. There are
no build logs to publish from these jobs.

This fixes the Prepare Installers stage failures in the internal
pipeline (e.g. dnceng/internal build 2969660).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 15, 2026 18:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17134

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17134"

@radical
Copy link
Copy Markdown
Member

radical commented May 15, 2026

This gets the winget/homebrew jobs green on the release/13.3 branch.

@davidfowl davidfowl merged commit 722c0b8 into release/13.3 May 20, 2026
7 checks passed
@github-actions github-actions Bot added this to the 13.3.x milestone May 20, 2026
joperezr added a commit that referenced this pull request May 21, 2026
…17343)

* Fix Azure provisioning disabled input values (#17291)

Accept server-provided values for disabled interaction inputs so dynamic Azure provisioning fields such as Location can be populated after selecting an existing resource group. Preserve local edits for enabled inputs.

Co-authored-by: Damian Edwards <damian@damianedwards.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [release/13.3] Stop forcing MSBuild server for Aspire CLI builds (#17314)

* Stop forcing MSBuild server for CLI dotnet commands

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Remove outdated override comment in DotNetCliRunner test

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Skip log publish for WinGet/Homebrew installer jobs (#17134)

These jobs only download already-built CLI archives and prepare
WinGet manifests / Homebrew casks; they never run the repo build,
so artifacts/log/$(_BuildConfig) is never produced. With
enablePublishBuildArtifacts: true, the Arcade 1ES job template
injects a Publish Logs pipelineArtifact output whose targetPath
points at that empty/missing directory. 1ES path validation on
that output fails the job (continueOnError on the CopyFiles step
doesn't help because the failure is on the 1ES publish output
itself).

Set enablePublishBuildArtifacts: false on the WinGet/Homebrew
installer stage in both the internal (azure-pipelines.yml) and
unofficial (azure-pipelines-unofficial.yml) pipelines. There are
no build logs to publish from these jobs.

This fixes the Prepare Installers stage failures in the internal
pipeline (e.g. dnceng/internal build 2969660).

Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Bump patch version from 13.3.4 to 13.3.5 (#17315)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>

* Revert "Bump patch version from 13.3.4 to 13.3.5 (#17315)"

This reverts commit 70b33bc.

---------

Co-authored-by: aspire-repo-bot[bot] <268009190+aspire-repo-bot[bot]@users.noreply.github.com>
Co-authored-by: Damian Edwards <damian@damianedwards.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants