docs(cli): fix staging/daily channel example in ScaffoldingService comment#17152
Closed
radical wants to merge 1 commit into
Closed
docs(cli): fix staging/daily channel example in ScaffoldingService comment#17152radical wants to merge 1 commit into
radical wants to merge 1 commit into
Conversation
…mment The comment example listed `daily` as the identity that could pin a channel without a matching PSM rule. That is backwards: `daily` is registered unconditionally in `PackagingService`, while `staging` is the channel gated behind the staging feature flag. Update the example to `staging` so the comment matches the actual channel-registration behavior. Follow-up to PR microsoft#17120 review feedback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17152Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17152" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to review feedback on #17120 (#17120 (comment)).
The comment in
ScaffoldingService.ScaffoldGuestLanguageAsyncuseddailyas the example of an identity that could pin a channel name without a matching PSM rule. That's inverted: inPackagingService,dailyis registered unconditionally, whilestagingis the channel gated behind the staging feature flag. Updated the example tostagingso the comment matches the actual channel-registration behavior.Comment-only change, no behavior impact.