Unpreview Aspire CLI deployment commands#17174
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17174Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17174" |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the "(Preview)" label from the deploy, destroy, do, publish, and update CLI command descriptions across resx/Designer/xlf files, and adds destroy to the README Deployment commands table.
Changes:
- Drop "(Preview)" from English source strings in 5 resx files and their Designer.cs summaries.
- Update all 13 localized xlf files for each command (source strings; cs.xlf targets also stripped of "(Preview)"; Destroy targets in "new" state mirror the English).
- README: remove "(Preview)" suffixes and add
destroyrow to Deployment table.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Cli/Resources/{Deploy,Destroy,Do,Publish,Update}CommandStrings.resx | Source strings unpreviewed |
| src/Aspire.Cli/Resources/{Deploy,Destroy,Do,Publish,Update}CommandStrings.Designer.cs | XML doc summaries updated |
| src/Aspire.Cli/Resources/xlf/*.xlf (13 locales × 5 commands) | Source updated; cs.xlf and Destroy *.xlf targets adjusted |
| src/Aspire.Cli/README.md | Removed "(Preview)" tags; added destroy row |
Note: Non-cs locale xlf targets still contain the translated "(Preview/预览/プレビュー/etc.)" suffix while their <source> no longer does, which is the expected behavior for UpdateXlf — those translations will be refreshed by the localization process (state already needs-review-translation). No action required.
Copilot's findings
Files not reviewed (5)
- src/Aspire.Cli/Resources/DeployCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/DestroyCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/DoCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/PublishCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/UpdateCommandStrings.Designer.cs: Language not supported
- Files reviewed: 71/76 changed files
- Comments generated: 0
Contributor
|
❓ CLI E2E Tests unknown — 85 passed, 0 failed, 1 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #25969562773 |
JamesNK
approved these changes
May 16, 2026
nellshamrell
pushed a commit
to nellshamrell/aspire
that referenced
this pull request
May 18, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CLI deployment/update commands are no longer preview, so the command help and CLI README should not label them that way. This updates the localized command description resources for
aspire deploy,aspire destroy,aspire do,aspire publish, andaspire update, and refreshes the related XLIFF source strings.The CLI README now also lists
destroyin the Deployment command table.User-facing usage
Root help now shows these commands without the preview moniker:
The dashboard command remains preview-labeled:
Validation:
dotnet build /t:UpdateXlf src/Aspire.Cli/Aspire.Cli.csprojdotnet build src/Aspire.Cli/Aspire.Cli.csproj /p:SkipNativeBuild=truedotnet artifacts/bin/Aspire.Cli/Debug/net10.0/aspire.dll --helpFixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?