Skip to content

Add server-side support for CLI dependent choice validation#17218

Closed
tayfun-akguc wants to merge 5 commits into
microsoft:mainfrom
tayfun-akguc:fix-16907-dependent-choice-validation
Closed

Add server-side support for CLI dependent choice validation#17218
tayfun-akguc wants to merge 5 commits into
microsoft:mainfrom
tayfun-akguc:fix-16907-dependent-choice-validation

Conversation

@tayfun-akguc
Copy link
Copy Markdown

@tayfun-akguc tayfun-akguc commented May 18, 2026

  • IsDynamic + DependsOnInputs on ResourceSnapshotCommandArgument so the CLI can tell dependent choices
  • New backchannel capability aux.v4 and LoadDynamicArgumentOptionsAsync RPC
  • Status enum + matching DTOs, registered in the CLI's JSON source-gen context

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #16907

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17218

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17218"

@tayfun-akguc
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@sebastienros
Copy link
Copy Markdown
Contributor

@davidfowl do you want to close this one?

@tayfun-akguc
Copy link
Copy Markdown
Author

@sebastienros @davidfowl
I read @davidfowl's comment as confirming the repro, not pointing to an existing fix. Want me to continue here, or is there parallel work? Happy to close either way.

@davidfowl
Copy link
Copy Markdown
Contributor

This is my draft pr #17249

@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 13.4 milestone May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI resource command does not validate dependent choice inputs

3 participants