Skip to content

Fix release pipeline: GitHubTasks stage deps and aspire-cli-* download pattern#17248

Merged
joperezr merged 2 commits into
microsoft:mainfrom
joperezr:joperezr/fix-release-pipeline-stage-deps
May 19, 2026
Merged

Fix release pipeline: GitHubTasks stage deps and aspire-cli-* download pattern#17248
joperezr merged 2 commits into
microsoft:mainfrom
joperezr:joperezr/fix-release-pipeline-stage-deps

Conversation

@joperezr
Copy link
Copy Markdown
Member

@joperezr joperezr commented May 19, 2026

Fixes two issues blocking a green run of the release pipeline.

1. ReleaseVersionEffective resolves to empty in GitHubTasks stage

The GitHubTasks stage's jobs reference

\\yaml ReleaseVersionEffective: $[ stageDependencies.PrepareArtifacts.PrepareJob.outputs['deriveReleaseVersion.releaseVersionEffective'] ] \\\

but the stage previously only declared dependsOn: Release. AzDO does not make stageDependencies transitive — only stages named directly in dependsOn are reachable — so the expression silently evaluated to empty and the GitHub workflow_dispatch failed with:

HTTP 422: Required input 'release_version' not provided

Confirmed in build 2978542 (log id 137). PrepareArtifacts is now listed alongside Release so the variable resolves.

2. aspire-cli-* download pattern matches zero files

In PublishReleaseAssetsJob, the download step used:

`\yaml

  • download: aspire-build
    artifact: BlobArtifacts
    patterns: 'aspire-cli-*'
    \`

The download task enumerates artifact items with the artifact name as a path prefix (e.g. BlobArtifacts/aspire-cli-linux-x64-13.3.4.tar.gz), so the bare aspire-cli-* minimatch glob excluded every file. Zero files were downloaded, the target directory was never created, and the next step failed with:

Assets directory 'D:\a\_work\1\aspire-build\BlobArtifacts' does not exist. Did the download step run?

Confirmed in build 2978586 (log id 163 shows 0 matches and every aspire-cli-* file Item excluded). Pattern is now **/aspire-cli-*.

Validation

Issue #1 confirmed fixed in dry-run build 2978586 (workflow_dispatch accepted with correct release_version); issue #2 surfaced in that same run as the next blocker and is fixed here.

Copilot AI review requested due to automatic review settings May 19, 2026 06:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17248

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17248"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes three release-pipeline blockers encountered while validating the chained AzDO→GitHub release flow: (1) removes an AzDO build tag emission that can fail request-path validation, (2) changes the source-build tag format to avoid : in tag names, and (3) fixes stage dependency wiring so ReleaseVersionEffective is available to the GitHub dispatch stage.

Changes:

  • Remove build.addbuildtag emission in the release pipeline to avoid AzDO request-path validation failures caused by : in tag names.
  • Switch the source-build tag format from release-version:<ver> to release-version - <ver> and update the release pipeline’s tag parsing accordingly.
  • Add PrepareArtifacts to GitHubTasks stage dependsOn so stageDependencies.PrepareArtifacts... outputs resolve correctly.
Show a summary per file
File Description
eng/pipelines/release-publish-nuget.yml Updates release-version tag parsing to release-version - <ver>, removes the problematic addbuildtag emission, and fixes GitHubTasks stage dependencies to ensure outputs are reachable.
eng/pipelines/azure-pipelines.yml Changes the emitted source-build tag format to release-version - <ver> to avoid : in tag names.
docs/release-process.md Updates release documentation to reflect the new release-version - <ver> tag format and auto-derivation behavior.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

…Effective resolves

The GitHubTasks stage's jobs reference
stageDependencies.PrepareArtifacts.PrepareJob.outputs['deriveReleaseVersion.releaseVersionEffective']
but the stage previously only declared dependsOn: Release. AzDO does not
make stageDependencies transitive, so the variable resolved to empty and
the workflow dispatch failed with:

  HTTP 422: Required input 'release_version' not provided

Confirmed in https://dev.azure.com/dnceng/internal/_build/results?buildId=2978542
(log id 137).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joperezr joperezr force-pushed the joperezr/fix-release-pipeline-stage-deps branch from 055e9b9 to 6242217 Compare May 19, 2026 06:51
@joperezr joperezr changed the title Fix release pipeline: addbuildtag, tag separator, and GitHubTasks stage deps Add PrepareArtifacts to GitHubTasks stage dependsOn so ReleaseVersionEffective resolves May 19, 2026
The download task enumerates artifact items with the artifact name as a
path prefix (e.g. 'BlobArtifacts/aspire-cli-linux-x64-13.3.4.tar.gz'),
so the bare 'aspire-cli-*' minimatch glob excluded every file. Result:
0 files downloaded, target directory never created, and the next step
failed with 'Assets directory ... does not exist. Did the download step
run?'

Confirmed in https://dev.azure.com/dnceng/internal/_build/results?buildId=2978586
(log id 163 shows '0 matches' and every aspire-cli-* file 'Item excluded').

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joperezr joperezr changed the title Add PrepareArtifacts to GitHubTasks stage dependsOn so ReleaseVersionEffective resolves Fix release pipeline: GitHubTasks stage deps and aspire-cli-* download pattern May 19, 2026
@joperezr joperezr merged commit e4f641e into microsoft:main May 19, 2026
6 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 13.4 milestone May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants