Fix release pipeline: GitHubTasks stage deps and aspire-cli-* download pattern#17248
Merged
joperezr merged 2 commits intoMay 19, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17248Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17248" |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes three release-pipeline blockers encountered while validating the chained AzDO→GitHub release flow: (1) removes an AzDO build tag emission that can fail request-path validation, (2) changes the source-build tag format to avoid : in tag names, and (3) fixes stage dependency wiring so ReleaseVersionEffective is available to the GitHub dispatch stage.
Changes:
- Remove
build.addbuildtagemission in the release pipeline to avoid AzDO request-path validation failures caused by:in tag names. - Switch the source-build tag format from
release-version:<ver>torelease-version - <ver>and update the release pipeline’s tag parsing accordingly. - Add
PrepareArtifactstoGitHubTasksstagedependsOnsostageDependencies.PrepareArtifacts...outputs resolve correctly.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/release-publish-nuget.yml | Updates release-version tag parsing to release-version - <ver>, removes the problematic addbuildtag emission, and fixes GitHubTasks stage dependencies to ensure outputs are reachable. |
| eng/pipelines/azure-pipelines.yml | Changes the emitted source-build tag format to release-version - <ver> to avoid : in tag names. |
| docs/release-process.md | Updates release documentation to reflect the new release-version - <ver> tag format and auto-derivation behavior. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
davidfowl
approved these changes
May 19, 2026
…Effective resolves The GitHubTasks stage's jobs reference stageDependencies.PrepareArtifacts.PrepareJob.outputs['deriveReleaseVersion.releaseVersionEffective'] but the stage previously only declared dependsOn: Release. AzDO does not make stageDependencies transitive, so the variable resolved to empty and the workflow dispatch failed with: HTTP 422: Required input 'release_version' not provided Confirmed in https://dev.azure.com/dnceng/internal/_build/results?buildId=2978542 (log id 137). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
055e9b9 to
6242217
Compare
The download task enumerates artifact items with the artifact name as a path prefix (e.g. 'BlobArtifacts/aspire-cli-linux-x64-13.3.4.tar.gz'), so the bare 'aspire-cli-*' minimatch glob excluded every file. Result: 0 files downloaded, target directory never created, and the next step failed with 'Assets directory ... does not exist. Did the download step run?' Confirmed in https://dev.azure.com/dnceng/internal/_build/results?buildId=2978586 (log id 163 shows '0 matches' and every aspire-cli-* file 'Item excluded'). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues blocking a green run of the release pipeline.
1.
ReleaseVersionEffectiveresolves to empty inGitHubTasksstageThe
GitHubTasksstage's jobs reference\\yaml ReleaseVersionEffective: $[ stageDependencies.PrepareArtifacts.PrepareJob.outputs['deriveReleaseVersion.releaseVersionEffective'] ] \\\but the stage previously only declared
dependsOn: Release. AzDO does not makestageDependenciestransitive — only stages named directly independsOnare reachable — so the expression silently evaluated to empty and the GitHub workflow_dispatch failed with:Confirmed in build 2978542 (log id 137).
PrepareArtifactsis now listed alongsideReleaseso the variable resolves.2.
aspire-cli-*download pattern matches zero filesIn
PublishReleaseAssetsJob, the download step used:`\yaml
artifact: BlobArtifacts
patterns: 'aspire-cli-*'
\`
The download task enumerates artifact items with the artifact name as a path prefix (e.g.
BlobArtifacts/aspire-cli-linux-x64-13.3.4.tar.gz), so the bareaspire-cli-*minimatch glob excluded every file. Zero files were downloaded, the target directory was never created, and the next step failed with:Confirmed in build 2978586 (log id 163 shows
0 matchesand everyaspire-cli-*fileItem excluded). Pattern is now**/aspire-cli-*.Validation
Issue #1 confirmed fixed in dry-run build 2978586 (workflow_dispatch accepted with correct
release_version); issue #2 surfaced in that same run as the next blocker and is fixed here.