Publish Aspire.Hosting.Integration.Analyzers as preview package#17276
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR enables publishing Aspire.Hosting.Integration.Analyzers as a standalone preview NuGet package so out-of-repo hosting integration authors can use the same ATS/polyglot authoring analyzers as in-repo integrations.
Changes:
- Makes
Aspire.Hosting.Integration.Analyzerspackable and configures its NuGet package metadata and analyzer asset layout. - Adds package documentation (package README + guidance in existing ATS attribute docs).
- Adds MSBuild-based tests to validate the produced nupkg contents and local-feed consumption.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/MSBuildTests.cs | Adds pack/build helpers and tests validating analyzer nupkg layout + local consumption. |
| src/Aspire.Hosting/Ats/ThirdPartyAtsAttributes.md | Documents how third-party integrations can reference the analyzer package. |
| src/Aspire.Hosting.Integration.Analyzers/README.md | Adds package README content intended to ship in the nupkg. |
| src/Aspire.Hosting.Integration.Analyzers/Aspire.Hosting.Integration.Analyzers.csproj | Makes the analyzer project packable and packs the analyzer assembly under analyzers/dotnet/cs. |
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17276Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17276" |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid loading the integration analyzer project into generated ATS scanner builds and exclude it from ATS workflow project discovery. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR Testing CompleteResult: ✅ PR #17276’s package-focused changes verified successfully. The new PR Information
Scenarios Executed
ObservationThe first That looks like a dogfood/template-source setup issue rather than part of this analyzer-packaging PR. CleanupThe local temp workspace and captured artifacts were removed:
Posted by GitHub Copilot CLI. |
Co-authored-by: David Pine <david.pine@microsoft.com>
Make the analyzer type internal and remove the generated public API baseline from source control. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use versionless package-reference examples for the integration analyzer package documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove redundant dependency suppression and avoid exact package versions in analyzer docs while keeping analyzer-only package metadata explicit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
❓ CLI E2E Tests unknown — 96 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26190714938 |
Description
This starts publishing Aspire.Hosting.Integration.Analyzers as a standalone preview NuGet package so out-of-repo integration authors can use the same ATS/polyglot analyzer guidance used in-repo.
It makes the analyzer project packable with preview package settings, adds a package README, and documents how third-party authors can reference the package. It also adds MSBuild tests that validate the nupkg layout (analyzers/dotnet/cs plus README, no dependency payload) and local-feed consumption in a sample project.
For docs links, there is not an equivalent aspire.dev page for third-party ATS attributes today, so the README points to repo docs/specs for now.
Fixes: #17264
Checklist
<remarks />and<code />elements on your triple slash comments?