Fix Azure provisioning resource group location prompt#17278
Merged
Conversation
Accept server-provided values for disabled interaction inputs so dynamic Azure provisioning fields such as Location can be populated after selecting an existing resource group. Preserve local edits for enabled inputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Azure provisioning dialog updates so disabled inputs can receive server-owned values, allowing the existing resource group flow to populate Location and proceed.
Changes:
- Updates
InputViewModel.SetInputto accept incoming values when an input is disabled. - Preserves existing local-edit behavior for enabled inputs.
- Adds unit coverage for disabled incoming values and enabled local value preservation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Aspire.Dashboard/Model/Interaction/InputViewModel.cs |
Centralizes incoming value selection and treats disabled inputs as server-owned. |
tests/Aspire.Dashboard.Tests/Model/InputViewModelTests.cs |
Adds regression tests for disabled and enabled SetInput value behavior. |
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17278Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17278" |
Contributor
|
❓ CLI E2E Tests unknown — 94 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26126925061 |
JamesNK
approved these changes
May 20, 2026
Member
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
Clean fix. The ShouldUseIncomingValue helper correctly treats disabled inputs as server-owned, resolving the stuck Location field when selecting an existing resource group. Logic is sound across all state transitions and well covered by the new tests.
Contributor
|
See the workflow run for details: https://github.com/microsoft/aspire/actions/runs/26134603903 Added an
|
Contributor
|
/backport to release/13.3 |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17275
The Azure provisioning dialog could get stuck when a user selected an existing resource group because the Location field was disabled, required, and sometimes left empty in the dashboard's local input model.
Users can now proceed after selecting an existing resource group. The disabled Location input accepts the server-provided resource group location, while enabled inputs still preserve in-progress local edits during interaction updates.
User-facing usage
In the Azure provisioning dialog, selecting an existing resource group now populates the disabled Location field with that resource group's location instead of leaving it empty and blocking submission.
Validation:
Checklist
<remarks />and<code />elements on your triple slash comments?