[release/13.4] Fix remaining issue 17244 items#17522
Merged
Merged
Conversation
Preserve legacy auxiliary backchannel resource property serialization unless clients opt in to JSON-valued properties, and remove the unused dashboard start command filter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the existing auxiliary backchannel V3 capability for typed resource properties and stop advertising a new V4 capability. Also limit the watch-resource capability test to the first streamed snapshot so it does not wait for a never-ending watch stream. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aspire-repo-bot
Bot
requested review from
JamesNK,
adamint,
danegsta,
davidfowl,
karolz-ms and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17522Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17522" |
mitchdenny
approved these changes
May 27, 2026
davidfowl
approved these changes
May 27, 2026
Contributor
|
❌ CLI E2E Tests failed — 106 passed, 1 failed, 2 unknown (commit Failed Tests
View all recordings
📹 Recordings uploaded automatically from CI run #26489967289 |
Contributor
Author
|
✅ No documentation update needed. docs_optional → No signals triggered (
The fix restores backward-compatible behavior for older CLI clients against a 13.4 AppHost. No new CLI options, configuration keys, public APIs, or dashboard pages were introduced or changed from a user perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #17507 to release/13.4
/cc @adamint
Customer Impact
Customers using older CLI/backchannel clients with a 13.4 AppHost could fail to read resource snapshots when resource properties contain non-string values, like container ports, booleans, arrays, or JSON objects. This keeps those legacy clients compatible while still letting newer clients opt in to typed JSON resource properties.
This also removes the duplicate dashboard Start-command filtering so the resource action menu uses the command model as the single source of truth.
Testing
Validated in the source PR with targeted Hosting, CLI, and Dashboard tests covering the backchannel compatibility path and
ResourceMenuBuilderbehavior. Also ran James's requested PR-tester compatibility pass with released CLI13.3.5against the PR AppHost package: legacy callers received string properties, andaux.v3callers received typed JSON. Results are posted at #17507 (comment).Risk
Low. The compatibility behavior is capability-gated and preserves the legacy string/null wire format unless the client advertises
aux.v3; the dashboard change removes a duplicate filter instead of adding new command behavior.Regression?
Yes