[release/13.4] Fix aspire stop falsely reporting failure on Unix

[aspire-repo-bot]

Backport of #17612 to release/13.4

/cc @danegsta

Customer Impact

Fixes a Unix/Linux aspire stop race condition that could cause us to fail to report a successful stop.

Testing

Validated via smoke tests in a Linux container.

Risk

Low - ultimately our process cleanup strategy doesn't change much, we're just being more careful about what PIDs we're watching/signaling during shutdown

Regression?

Yes, in 13.4

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17623

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17623"

[github-actions]

❓ CLI E2E Tests unknown — 107 passed, 0 failed, 2 unknown (commit b22542c)

View all recordings

Status	Test	Recording	Job	Artifacts
✅	AddPackageInteractiveWhileAppHostRunningDetached	Recording	#78395726607	Logs
✅	AddPackageWhileAppHostRunningDetached	Recording	#78395726607	Logs
✅	AgentCommands_AllHelpOutputs_AreCorrect	Recording	#78395727276	Logs
✅	AgentInitCommand_DefaultSelection_InstallsDefaultSkills	Recording	#78395727276	Logs
✅	AgentInitCommand_MigratesDeprecatedConfig	Recording	#78395727276	Logs
✅	AgentMcpListStructuredLogsReturnsLogsFromStarterApp	Recording	#78395725687	Logs
✅	AgentMcpListStructuredLogsReturnsLogsFromStarterApp_DevLocalhost	Recording	#78395725687	Logs
✅	AgentMcpListStructuredLogsReturnsLogsFromStarterApp_Isolated	Recording	#78395725687	Logs
✅	AllPublishMethodsBuildDockerImages	Recording	#78395725765	Logs
✅	AspireAddAndStartWorkAgainstLegacyAppHostTs	Recording	#78395726521	Logs
✅	AspireAddPackageVersionToDirectoryPackagesProps	Recording	#78395727019	Logs
✅	AspireInitSingleFileAppHostRunsViaDotnetRunAppHost	Recording	#78395725829	Logs
✅	AspireInitWithExistingAppHostDirRecreatesMissingNuGetConfigAndPreservesFiles	Recording	#78395726082	Logs
❔	AspireInitWithSolutionFileGeneratesAppHostThatBuildsAgainstChannelHive	Recording	#78395726082	Logs
✅	AspireStartUpdatesStaleTypeScriptAppHostPath	Recording	#78395726694	Logs
✅	AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps	Recording	#78395727019	Logs
✅	AspireUpdateRemovesOrphanAppHostPackageVersionWhenSdkAlreadyCurrent	Recording	#78395727019	Logs
✅	Banner_DisplayedOnFirstRun	Recording	#78395727087	Logs
✅	Banner_DisplayedWithExplicitFlag	Recording	#78395727087	Logs
✅	Banner_NotDisplayedWithNoLogoFlag	Recording	#78395727087	Logs
✅	CertificatesClean_RemovesCertificates	Recording	#78395726073	Logs
✅	CertificatesTrust_WithNoCert_CreatesAndTrustsCertificate	Recording	#78395726073	Logs
✅	CertificatesTrust_WithUntrustedCert_TrustsCertificate	Recording	#78395726073	Logs
✅	ConfigSetGet_CreatesNestedJsonFormat	Recording	#78395726184	Logs
✅	CreateAndRunAspireStarterProject	Recording	#78395727007	Logs
✅	CreateAndRunAspireStarterProjectWithBundle	Recording	#78395726845	Logs
✅	CreateAndRunEmptyAppHostProject	Recording	#78395727239	Logs
✅	CreateAndRunJavaEmptyAppHostProject	Recording	#78395726912	Logs
✅	CreateAndRunJsReactProject	Recording	#78395726822	Logs
✅	CreateAndRunPythonReactProject	Recording	#78395725851	Logs
✅	CreateAndRunTypeScriptEmptyAppHostProject	Recording	#78395726158	Logs
✅	CreateAndRunTypeScriptStarterProject	Recording	#78395726211	Logs
✅	CreateJavaAppHostWithViteApp	Recording	#78395725754	Logs
✅	CreateTypeScriptAppHostWithViteApp_AllowsGuestAppPackageManagerToDiffer	Recording	#78395725991	Logs
✅	CreateTypeScriptAppHostWithViteApp_UsesConfiguredToolchain	Recording	#78395725991	Logs
✅	DashboardRunWithAgentMcpListTracesReturnsNoTraces	Recording	#78395725766	Logs
✅	DashboardRunWithAgentMcpListTracesReturnsNoTraces_DevLocalhost	Recording	#78395725766	Logs
✅	DashboardRunWithOtelTracesReturnsNoTraces	Recording	#78395725766	Logs
✅	DashboardRunWithOtelTracesReturnsNoTraces_DevLocalhost	Recording	#78395725766	Logs
✅	DeployK8sBasicApiService	Recording	#78395725860	Logs
✅	DeployK8sWithExternalHelmChart	Recording	#78395726355	Logs
✅	DeployK8sWithGarnet	Recording	#78395727169	Logs
✅	DeployK8sWithMongoDB	Recording	#78395726699	Logs
✅	DeployK8sWithMySql	Recording	#78395726120	Logs
✅	DeployK8sWithPostgres	Recording	#78395726572	Logs
✅	DeployK8sWithRabbitMQ	Recording	#78395725614	Logs
✅	DeployK8sWithRedis	Recording	#78395725880	Logs
✅	DeployK8sWithSqlServer	Recording	#78395725998	Logs
✅	DeployK8sWithValkey	Recording	#78395726640	Logs
✅	DeployTypeScriptAppToKubernetes	Recording	#78395726153	Logs
✅	DescribeCommandResolvesReplicaNames	Recording	#78395726089	Logs
✅	DescribeCommandShowsRunningResources	Recording	#78395726089	Logs
✅	DetachFormatJsonProducesValidJson	Recording	#78395725863	Logs
✅	DetachFormatJsonProducesValidJsonWhenRestartingExistingInstance	Recording	#78395725863	Logs
✅	DoPublishAndDeployListStepsWork	Recording	#78395726945	Logs
✅	DocsCommand_RendersInteractiveMarkdownFromLocalSource	Recording	#78395726791	Logs
✅	DoctorCommand_DetectsDeprecatedAgentConfig	Recording	#78395727276	Logs
✅	DoctorCommand_TypeScriptAppHostReportsMissingConfiguredToolchain	Recording	#78395725699	Logs
✅	DoctorCommand_WithSslCertDir_ShowsTrusted	Recording	#78395725699	Logs
✅	DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted	Recording	#78395725699	Logs
✅	GatewayWithoutExternalEndpoint_FailsPublishWithGuidance	Recording	#78395725263	Logs
✅	GeneratedAspireDevScript_StartsWatchMode_WithConfiguredToolchain	Recording	#78395725991	Logs
✅	GlobalMigration_HandlesCommentsAndTrailingCommas	Recording	#78395726184	Logs
✅	GlobalMigration_HandlesMalformedLegacyJson	Recording	#78395726184	Logs
✅	GlobalMigration_PreservesAllValueTypes	Recording	#78395726184	Logs
✅	GlobalMigration_SkipsWhenNewConfigExists	Recording	#78395726184	Logs
✅	GlobalSettings_MigratedFromLegacyFormat	Recording	#78395726184	Logs
✅	IngressWithoutExternalEndpoint_FailsPublishWithGuidance	Recording	#78395725263	Logs
✅	InitTypeScriptAppHost_AugmentsExistingViteRepoInWorkspaceSubdirectory	Recording	#78395725991	Logs
✅	InteractiveCSharpInitCreatesExpectedFiles	Recording	#78395726186	Logs
✅	InvalidAppHostPathWithComments_IsHealedOnRun	Recording	#78395725639	Logs
✅	JavaScriptHostingApisRunFromTypeScriptAppHost	Recording	#78395725765	Logs
✅	LatestCliCanStartStableChannelAppHost	Recording	#78395727007	Logs
✅	LatestCliCanStartStableChannelTypeScriptAppHost	Recording	#78395727007	Logs
✅	LegacySettingsMigration_AdjustsRelativeAppHostPath	Recording	#78395726694	Logs
✅	LogsCommandShowsResourceLogs	Recording	#78395726232	Logs
✅	OtelLogsReturnsStructuredLogsFromStarterApp	Recording	#78395726339	Logs
✅	OtelLogsReturnsStructuredLogsFromStarterAppIsolated	Recording	#78395726339	Logs
✅	PsCommandListsRunningAppHost	Recording	#78395726250	Logs
✅	PsFormatJsonOutputsOnlyJsonToStdout	Recording	#78395726250	Logs
✅	PublishJavaScriptPatternsGeneratesExpectedDockerComposeArtifacts	Recording	#78395726997	Logs
✅	PublishWithConfigureEnvFileUpdatesEnvOutput	Recording	#78395726997	Logs
✅	PublishWithDockerComposeServiceCallbackSucceeds	Recording	#78395726997	Logs
✅	PublishWithoutOutputPathUsesAppHostDirectoryDefault	Recording	#78395726997	Logs
✅	ResourceCommand_FailedExecution_DisplaysAppHostLogPathAndLogContainsEntries	Recording	#78395726695	Logs
✅	ResourceCommand_SetAndDeleteParameterUpdatesDescribeOutput	Recording	#78395726695	Logs
✅	RestoreGeneratesSdkFiles	Recording	#78395725753	Logs
✅	RestoreGeneratesSdkFiles_WithConfiguredToolchain	Recording	#78395726468	Logs
✅	RestoreRefreshesGeneratedSdkAfterAddingIntegration	Recording	#78395726468	Logs
✅	RestoreSupportsConfigOnlyHelperPackageAndCrossPackageTypes	Recording	#78395725900	Logs
✅	RunFromParentDirectory_UsesExistingConfigNearAppHost	Recording	#78395727012	Logs
✅	RunReportsSyntaxErrorsForDotNetAppHost	Recording	#78395726874	Logs
✅	RunReportsSyntaxErrorsForTypeScriptAppHost	Recording	#78395726874	Logs
✅	SecretCrudOnDotNetAppHost	Recording	#78395726157	Logs
✅	SecretCrudOnTypeScriptAppHost	Recording	#78395726106	Logs
✅	StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels	Recording	#78395727262	Logs
✅	StartAndWaitForTypeScriptSqlServerAppHostWithNativeAssets	Recording	#78395725721	Logs
✅	StartReportsSyntaxErrorsForDotNetAppHost	Recording	#78395726874	Logs
✅	StartReportsSyntaxErrorsForTypeScriptAppHost	Recording	#78395726874	Logs
✅	StopAllAppHostsFromAppHostDirectory	Recording	#78395725697	Logs
✅	StopJavaPolyglotAppHostUsingApphostDirectory	Recording	#78395726240	Logs
✅	StopNonInteractiveSingleAppHost	Recording	#78395725697	Logs
✅	StopTypeScriptPolyglotAppHostUsingApphostDirectory	Recording	#78395727158	Logs
✅	StopWithNoRunningAppHostExitsSuccessfully	Recording	#78395726607	Logs
✅	UnAwaitedChainsCompileWithAutoResolvePromises	Recording	#78395726468	Logs
❔	UpdateProjectChannelToStable_CSharpEmptyAppHost_PreservesAspireConfigChannel	Recording	#78395725667	Logs
✅	UpdateProjectChannelToStable_CSharpSingleFileInit_PreservesAspireConfigChannel	Recording	#78395725667	Logs
✅	UpdateProjectChannelToStable_TypeScriptSingleFileInit_PreservesAspireConfigChannel	Recording	#78395725667	Logs
✅	UpdateProjectChannelToStable_TypeScript_PreviewsStablePackagesAndPreservesChannel	Recording	#78395725667	Logs

---

_{📹 Recordings uploaded automatically from CI run #26600615811}

[aspire-repo-bot]

✅ No documentation update needed.

docs_optional → bug_fix_restores_documented_behavior

No triggered signals (signal_count = 0). This is a Unix race-condition fix for aspire stop falsely reporting failure — the fix restores the already-documented behavior where aspire stop succeeds when the AppHost stops. The changed files are src/Aspire.Cli/Processes/ProcessShutdownService.cs, src/Shared/ProcessSignaler.cs, and a test file — all internal implementation changes with no new flags, options, commands, or public API surface.