Skip to content

[release/13.4] Remove Corepack from extension build scripts#17628

Merged
joperezr merged 1 commit into
microsoft:release/13.4from
joperezr:revert-extension-corepack-13.4
May 28, 2026
Merged

[release/13.4] Remove Corepack from extension build scripts#17628
joperezr merged 1 commit into
microsoft:release/13.4from
joperezr:revert-extension-corepack-13.4

Conversation

@joperezr
Copy link
Copy Markdown
Member

Description

Reverts the Corepack-specific Yarn invocation from the 13.4 branch VS Code extension build scripts.

Internal Azure Pipelines builds run with network isolation, and corepack yarn@1.22.22 attempts to download Yarn from the public Yarn registry before the extension's .yarnrc package registry configuration is used. That public download is blocked in internal builds. For 13.4, use the lower-risk fix of invoking the configured yarn executable directly again while preserving the Yarn-only/frozen-lockfile restore path.

Validation:

  • git diff --check
  • Parsed extension\Extension.proj as XML
  • Confirmed no corepack references remain in the targeted extension build files

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Revert the Corepack-specific Yarn invocation added to the extension build so internal Azure Pipelines builds use the configured Yarn executable instead of downloading Yarn from the public registry.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 28, 2026 21:06
@joperezr joperezr requested a review from adamint as a code owner May 28, 2026 21:06
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17628

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17628"

@joperezr
Copy link
Copy Markdown
Member Author

Merging to unblock the intenral build.

@joperezr joperezr merged commit a0823e6 into microsoft:release/13.4 May 28, 2026
17 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants