Skip to content

[release/13.4] Improve dashboard summary log formatting#17640

Merged
davidfowl merged 2 commits into
release/13.4from
backport/pr-17595-to-release/13.4
May 29, 2026
Merged

[release/13.4] Improve dashboard summary log formatting#17640
davidfowl merged 2 commits into
release/13.4from
backport/pr-17595-to-release/13.4

Conversation

@aspire-repo-bot
Copy link
Copy Markdown
Contributor

@aspire-repo-bot aspire-repo-bot Bot commented May 29, 2026

Backport of #17595 to release/13.4

/cc @JamesNK

Customer Impact

Improves a very user visible log message

Testing

Manual and automated testing

Risk

Very low

Regression?

Copilot AI review requested due to automatic review settings May 29, 2026 01:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17640

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17640"

@JamesNK JamesNK added the Servicing-consider Issue for next servicing release review label May 29, 2026
@JamesNK JamesNK added this to the 13.4 milestone May 29, 2026
JamesNK and others added 2 commits May 29, 2026 22:21
- Indent URL lines with 6 spaces and '- ' prefix so they align with
  the standard log output indentation
- Move container warning to a separate log message with clearer text
- Update tests to match new format
…er log message

Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
@JamesNK JamesNK force-pushed the backport/pr-17595-to-release/13.4 branch from d244be5 to 31b5c80 Compare May 29, 2026 14:25
@github-actions
Copy link
Copy Markdown
Contributor

CLI E2E Tests unknown — 108 passed, 0 failed, 2 unknown (commit 31b5c80)

View all recordings
Status Test Recording Job Artifacts
AddPackageInteractiveWhileAppHostRunningDetached Recording #78526347644 Logs
AddPackageWhileAppHostRunningDetached Recording #78526347644 Logs
AgentCommands_AllHelpOutputs_AreCorrect Recording #78526347648 Logs
AgentInitCommand_DefaultSelection_InstallsDefaultSkills Recording #78526347648 Logs
AgentInitCommand_MigratesDeprecatedConfig Recording #78526347648 Logs
AgentMcpListStructuredLogsReturnsLogsFromStarterApp Recording #78526347699 Logs
AgentMcpListStructuredLogsReturnsLogsFromStarterApp_DevLocalhost Recording #78526347699 Logs
AgentMcpListStructuredLogsReturnsLogsFromStarterApp_Isolated Recording #78526347699 Logs
AllPublishMethodsBuildDockerImages Recording #78526347604 Logs
AspireAddAndStartWorkAgainstLegacyAppHostTs Recording #78526348364 Logs
AspireAddPackageVersionToDirectoryPackagesProps Recording #78526346877 Logs
AspireInitSingleFileAppHostRunsViaDotnetRunAppHost Recording #78526348266 Logs
AspireInitWithExistingAppHostDirRecreatesMissingNuGetConfigAndPreservesFiles Recording #78526346998 Logs
AspireInitWithSolutionFileGeneratesAppHostThatBuildsAgainstChannelHive Recording #78526346998 Logs
AspireStartUpdatesStaleTypeScriptAppHostPath Recording #78526348139 Logs
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps Recording #78526346877 Logs
AspireUpdateRemovesOrphanAppHostPackageVersionWhenSdkAlreadyCurrent Recording #78526346877 Logs
Banner_DisplayedOnFirstRun Recording #78526348235 Logs
Banner_DisplayedWithExplicitFlag Recording #78526348235 Logs
Banner_NotDisplayedWithNoLogoFlag Recording #78526348235 Logs
CertificatesClean_RemovesCertificates Recording #78526347643 Logs
CertificatesTrust_WithNoCert_CreatesAndTrustsCertificate Recording #78526347643 Logs
CertificatesTrust_WithUntrustedCert_TrustsCertificate Recording #78526347643 Logs
ConfigSetGet_CreatesNestedJsonFormat Recording #78526347948 Logs
CreateAndRunAspireStarterProject Recording #78526347850 Logs
CreateAndRunAspireStarterProjectWithBundle Recording #78526347696 Logs
CreateAndRunEmptyAppHostProject Recording #78526347743 Logs
CreateAndRunJavaEmptyAppHostProject Recording #78526347713 Logs
CreateAndRunJsReactProject Recording #78526347392 Logs
CreateAndRunPolyglotAppHostWithDevLocalhostUrls Recording #78526347850 Logs
CreateAndRunPythonReactProject Recording #78526347982 Logs
CreateAndRunTypeScriptEmptyAppHostProject Recording #78526348079 Logs
CreateAndRunTypeScriptStarterProject Recording #78526347555 Logs
CreateJavaAppHostWithViteApp Recording #78526348335 Logs
CreateTypeScriptAppHostWithViteApp_AllowsGuestAppPackageManagerToDiffer Recording #78526347857 Logs
CreateTypeScriptAppHostWithViteApp_UsesConfiguredToolchain Recording #78526347857 Logs
DashboardRunWithAgentMcpListTracesReturnsNoTraces Recording #78526347725 Logs
DashboardRunWithAgentMcpListTracesReturnsNoTraces_DevLocalhost Recording #78526347725 Logs
DashboardRunWithOtelTracesReturnsNoTraces Recording #78526347725 Logs
DashboardRunWithOtelTracesReturnsNoTraces_DevLocalhost Recording #78526347725 Logs
DeployK8sBasicApiService Recording #78526348440 Logs
DeployK8sWithExternalHelmChart Recording #78526348318 Logs
DeployK8sWithGarnet Recording #78526347567 Logs
DeployK8sWithMongoDB Recording #78526348036 Logs
DeployK8sWithMySql Recording #78526349127 Logs
DeployK8sWithPostgres Recording #78526348488 Logs
DeployK8sWithRabbitMQ Recording #78526348346 Logs
DeployK8sWithRedis Recording #78526348447 Logs
DeployK8sWithSqlServer Recording #78526348053 Logs
DeployK8sWithValkey Recording #78526350265 Logs
DeployTypeScriptAppToKubernetes Recording #78526348140 Logs
DescribeCommandResolvesReplicaNames Recording #78526347709 Logs
DescribeCommandShowsRunningResources Recording #78526347709 Logs
DetachFormatJsonProducesValidJson Recording #78526347647 Logs
DetachFormatJsonProducesValidJsonWhenRestartingExistingInstance Recording #78526347647 Logs
DoPublishAndDeployListStepsWork Recording #78526348592 Logs
DocsCommand_RendersInteractiveMarkdownFromLocalSource Recording #78526347988 Logs
DoctorCommand_DetectsDeprecatedAgentConfig Recording #78526347648 Logs
DoctorCommand_TypeScriptAppHostReportsMissingConfiguredToolchain Recording #78526347799 Logs
DoctorCommand_WithSslCertDir_ShowsTrusted Recording #78526347799 Logs
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted Recording #78526347799 Logs
GatewayWithoutExternalEndpoint_FailsPublishWithGuidance Recording #78526347823 Logs
GeneratedAspireDevScript_StartsWatchMode_WithConfiguredToolchain Recording #78526347857 Logs
GlobalMigration_HandlesCommentsAndTrailingCommas Recording #78526347948 Logs
GlobalMigration_HandlesMalformedLegacyJson Recording #78526347948 Logs
GlobalMigration_PreservesAllValueTypes Recording #78526347948 Logs
GlobalMigration_SkipsWhenNewConfigExists Recording #78526347948 Logs
GlobalSettings_MigratedFromLegacyFormat Recording #78526347948 Logs
IngressWithoutExternalEndpoint_FailsPublishWithGuidance Recording #78526347823 Logs
InitTypeScriptAppHost_AugmentsExistingViteRepoInWorkspaceSubdirectory Recording #78526347857 Logs
InteractiveCSharpInitCreatesExpectedFiles Recording #78526348569 Logs
InvalidAppHostPathWithComments_IsHealedOnRun Recording #78526347997 Logs
JavaScriptHostingApisRunFromTypeScriptAppHost Recording #78526347604 Logs
LatestCliCanStartStableChannelAppHost Recording #78526347850 Logs
LatestCliCanStartStableChannelTypeScriptAppHost Recording #78526347850 Logs
LegacySettingsMigration_AdjustsRelativeAppHostPath Recording #78526348139 Logs
LogsCommandShowsResourceLogs Recording #78526348188 Logs
OtelLogsReturnsStructuredLogsFromStarterApp Recording #78526348047 Logs
OtelLogsReturnsStructuredLogsFromStarterAppIsolated Recording #78526348047 Logs
PsCommandListsRunningAppHost Recording #78526347742 Logs
PsFormatJsonOutputsOnlyJsonToStdout Recording #78526347742 Logs
PublishJavaScriptPatternsGeneratesExpectedDockerComposeArtifacts Recording #78526347927 Logs
PublishWithConfigureEnvFileUpdatesEnvOutput Recording #78526347927 Logs
PublishWithDockerComposeServiceCallbackSucceeds Recording #78526347927 Logs
PublishWithoutOutputPathUsesAppHostDirectoryDefault Recording #78526347927 Logs
ResourceCommand_FailedExecution_DisplaysAppHostLogPathAndLogContainsEntries Recording #78526347853 Logs
ResourceCommand_SetAndDeleteParameterUpdatesDescribeOutput Recording #78526347853 Logs
RestoreGeneratesSdkFiles Recording #78526347665 Logs
RestoreGeneratesSdkFiles_WithConfiguredToolchain Recording #78526347706 Logs
RestoreRefreshesGeneratedSdkAfterAddingIntegration Recording #78526347706 Logs
RestoreSupportsConfigOnlyHelperPackageAndCrossPackageTypes Recording #78526347667 Logs
RunFromParentDirectory_UsesExistingConfigNearAppHost Recording #78526347985 Logs
RunReportsSyntaxErrorsForDotNetAppHost Recording #78526348062 Logs
RunReportsSyntaxErrorsForTypeScriptAppHost Recording #78526348062 Logs
SecretCrudOnDotNetAppHost Recording #78526347675 Logs
SecretCrudOnTypeScriptAppHost Recording #78526347748 Logs
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels Recording #78526347903 Logs
StartAndWaitForTypeScriptSqlServerAppHostWithNativeAssets Recording #78526347958 Logs
StartReportsSyntaxErrorsForDotNetAppHost Recording #78526348062 Logs
StartReportsSyntaxErrorsForTypeScriptAppHost Recording #78526348062 Logs
StopAllAppHostsFromAppHostDirectory Recording #78526348342 Logs
StopJavaPolyglotAppHostUsingApphostDirectory Recording #78526348201 Logs
StopNonInteractiveSingleAppHost Recording #78526348342 Logs
StopTypeScriptPolyglotAppHostUsingApphostDirectory Recording #78526349357 Logs
StopWithNoRunningAppHostExitsSuccessfully Recording #78526347644 Logs
UnAwaitedChainsCompileWithAutoResolvePromises Recording #78526347706 Logs
UpdateProjectChannelToStable_CSharpEmptyAppHost_PreservesAspireConfigChannel Recording #78526347635 Logs
UpdateProjectChannelToStable_CSharpSingleFileInit_PreservesAspireConfigChannel Recording #78526347635 Logs
UpdateProjectChannelToStable_TypeScriptSingleFileInit_PreservesAspireConfigChannel Recording #78526347635 Logs
UpdateProjectChannelToStable_TypeScript_PreviewsStablePackagesAndPreservesChannel Recording #78526347635 Logs

📹 Recordings uploaded automatically from CI run #26642923104

@davidfowl davidfowl merged commit cbc3523 into release/13.4 May 29, 2026
616 of 619 checks passed
@davidfowl davidfowl deleted the backport/pr-17595-to-release/13.4 branch May 29, 2026 16:14
@microsoft-github-policy-service microsoft-github-policy-service Bot modified the milestone: 13.4 May 29, 2026
@aspire-repo-bot
Copy link
Copy Markdown
Contributor Author

✅ No documentation update needed.

docs_optional → internal_refactor: No documentation PR needed.

  • No signals triggered (signal_count = 0).
  • All 3 changed files are either an internal shared helper (src/Shared/LoggingHelpers.cs) or test files (tests/Aspire.Dashboard.Tests/...).
  • The change improves the formatting of the dashboard startup log output (adding - bullet prefixes, aligning URLs under the .NET console logger indentation, and splitting the container warning into a separate LogInformation call). This is a purely internal formatting/readability improvement with no public API, CLI flags, configuration keys, or documented surface affected.
  • The aspire.dev documentation does not describe the specific text or format of these startup log messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Servicing-consider Issue for next servicing release review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants