[release/13.4] Restore dotnet watch dashboard auto-launch signal#17653
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17653Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17653" |
There was a problem hiding this comment.
Pull request overview
This backport restores a legacy dashboard “login” log line that dotnet watch relies on to detect when an Aspire AppHost is serving HTTP traffic and auto-launch the dashboard browser, addressing a regression introduced in 13.4’s dashboard summary refactor.
Changes:
- Reintroduced an explicit
LogInformationcompatibility line:Login to the dashboard at {LoginUrl}when a login URL is available. - Updated unit/integration tests to expect the additional log entry and validate the structured
LoginUrlvalue. - Extended AppHost dashboard-ready event handler test coverage to assert the legacy login log is emitted.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/LoggingHelpers.cs | Emits the legacy “Login to the dashboard…” log line (structured) ahead of the existing dashboard summary output. |
| tests/Aspire.Dashboard.Tests/LoggingHelpersTests.cs | Updates expectations to account for the additional login log entry and validates its structured fields/message. |
| tests/Aspire.Dashboard.Tests/Integration/FrontendBrowserTokenAuthTests.cs | Adjusts log-output sequence assertions to include the restored legacy login log and validates token query presence. |
| tests/Aspire.Hosting.Tests/Dashboard/DashboardEventHandlersTests.cs | Adds assertion that the AppHost dashboard-ready path emits the legacy login log with the expected URL. |
|
❓ CLI E2E Tests unknown — 107 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26624564084 |
|
✅ No documentation update needed. docs_optional → bug_fix_restores_documented_behavior No triggered signals (signal_count = 0, recommendation = This PR is a backport (from #17610) that restores a regression: All 4 changed files are implementation ( |
Backport of #17610 to release/13.4
/cc @JamesNK
Customer Impact
dotnet watch cannot automatically open the dashboard browser when running an Aspire 13.4 AppHost. This is a regression from 13.3 — the legacy login log line that dotnet watch depends on to detect when the AppHost is serving HTTP traffic was removed in the new dashboard summary refactoring.
Fixes #17591
Testing
Unit tests added/updated covering the shared dashboard logging helper, the dashboard browser token auth integration test, and the AppHost dashboard-ready event handler. All tests pass on the release/13.4 branch.
Risk
Very low. Adds a single additional LogInformation call before the existing dashboard summary output. No behavioral change to any other code path.
Regression?
Yes — regressed in 13.4 when the dashboard summary output was refactored and the legacy login line was dropped.