[release/13.4] Assert allocated dashboard service URI has expected host and non-zero port#17741
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17741Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17741" |
There was a problem hiding this comment.
Pull request overview
Cherry-pick to release/13.4 updating dashboard dynamic-port tests to assert that the allocated dashboard resource service endpoint resolves to the expected loopback host and a non-zero (allocated) port.
Changes:
- Replace “wait for dashboard healthy” assertions with direct inspection of the allocated resource service URI via
DashboardServiceHost.GetResourceServiceUriAsync(). - Add host/port assertions for both default dynamic-port configuration and explicit loopback endpoint configurations.
| [InlineData("https://[::1]:0")] | ||
| public async Task LoopbackWithDynamicPorts(string endpointUrl) | ||
| [InlineData("https://127.0.0.1:0", "127.0.0.1")] | ||
| [InlineData("https://[::1]:0", "[::1]")] |
|
❓ CLI E2E Tests unknown — 110 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26699770867 |
|
✅ No documentation update needed. docs_optional → |
Summary
Cherry-pick of 20c2b87 to release/13.4.
Updates
DashboardEnabledInTestingBuilderShouldWorkWithDynamicPortsandLoopbackWithDynamicPortstests to assert the allocated dashboard service URI has the expected host and a non-zero port.Fixes
Fixes tests failing from #17731