[do not review] Add Manage Data selection accessible names#17784
[do not review] Add Manage Data selection accessible names#17784adamint wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17784Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17784" |
|
Uploaded annotated evidence artifacts here: https://github.com/adamint/aspire/tree/a11y-artifacts-20260601042635/17467 Most useful files:
The before capture shows nested selection buttons with missing/non-action names. The after capture shows action-oriented labels such as Draft fix PR: #17784 |
|
I verified this in a real browser with Playwright against Steps: open Settings, click Manage, and inspect the selection controls in the Manage data dialog. On Proof: {"pr":"17784","phase":"base","names":[]}
{"pr":"17784","phase":"pr","names":["Deselect all","Deselect TestResource","Deselect TestResource child"]} |
|
Adding the visual proof too; the earlier verification comment had the browser details but the proof was too JSON-heavy. I used Chromium against seeded dashboard mock host with main / before: No nested resource expander was rendered; captured the visible selection controls. Accessible names found: Close, Tooltip, Export selected, Remove selected, Import logs and telemetry this PR / after: No nested resource expander was rendered; captured the visible selection controls. Accessible names found: Close, Tooltip, Deselect all, Export selected, Remove selected, Import logs and telemetry MP4 proof, not webm, with visible keyboard/mouse/focus trace overlay: https://raw.githubusercontent.com/adamint/aspire/cd33e79ec249a7354240cc851b921502ada33d1a/proof/a11y/17784/pr-17784-visual-proof.mp4 Contact sheet with the before/after screenshots: https://raw.githubusercontent.com/adamint/aspire/cd33e79ec249a7354240cc851b921502ada33d1a/proof/a11y/17784/pr-17784-contact-sheet.png |
|
Condensed into #17928 to keep the Manage Data selection a11y changes together. Closing this smaller draft. |

Description
Fixes #17467
The Manage logs and telemetry dialog selection buttons now expose meaningful accessible names. Previously several icon-only selection buttons had no useful accessible name, so screen reader users could not tell which selection control they were operating.
The labels now describe the action and target:
This stays scoped to accessible names only; checkbox role/state semantics are left for the separate role issue.
User-facing usage
Screen reader users can distinguish the Manage Data selection controls, including duplicate data types across different resources. Annotated evidence captures the before state with missing nested labels and the after state with action-oriented labels that include the parent resource.
Checklist
<remarks />and<code />elements on your triple slash comments?