[do not review] Use select for text visualizer format picker#17787
[do not review] Use select for text visualizer format picker#17787adamint wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17787Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17787" |
|
Uploaded annotated evidence artifacts here: https://github.com/adamint/aspire/tree/a11y-artifacts-20260601042635/17498 Most useful files:
The before capture shows Select format as a button/menu-style control. The after capture shows a Draft fix PR: #17787 |
|
I verified this in a real browser with Playwright against Steps: open the resource text visualizer and inspect the format picker. On Proof: {"pr":"17787","phase":"base","button":"Select format","selectCount":0}
{"pr":"17787","phase":"pr","selectCount":1,"selectTag":"FLUENT-SELECT","aria":"Select format"} |
|
Adding the visual proof too; the earlier verification comment had the browser details but the proof was too JSON-heavy. I used Chromium against seeded dashboard mock host with main / before: Format controls: FLUENT-BUTTON: Select format; FLUENT-BUTTON: Close; FLUENT-BUTTON: Copy to clipboard this PR / after: Format controls: FLUENT-SELECT: Select format; FLUENT-BUTTON: Close; FLUENT-BUTTON: Copy to clipboard MP4 proof, not webm, with visible keyboard/mouse/focus trace overlay: https://raw.githubusercontent.com/adamint/aspire/cd33e79ec249a7354240cc851b921502ada33d1a/proof/a11y/17787/pr-17787-visual-proof.mp4 Contact sheet with the before/after screenshots: https://raw.githubusercontent.com/adamint/aspire/cd33e79ec249a7354240cc851b921502ada33d1a/proof/a11y/17787/pr-17787-contact-sheet.png |
|
Condensed into #17929 to keep the dialog/control a11y changes together. Closing this smaller draft. |

Description
Fixes #17498
The Text Visualizer dialog now uses a
FluentSelectfor the format picker instead of a menu-style button. This gives the format picker standard keyboard selection behavior while preserving the available/disabled format options, fixed-format hiding, and user-selected format across parent re-renders.User-facing usage
The Select format control now renders as a select/listbox control with options:
Annotated evidence captured the before state as a
Select formatbutton and the after state as afluent-selectwitharia-label="Select format"and keyboard-accessible options.Checklist
<remarks />and<code />elements on your triple slash comments?