Skip to content

Fix replica selection runtime error in dashboard#2262

Merged
JamesNK merged 4 commits intomainfrom
jamesnk/fix-replica-runtime-error
Feb 17, 2024
Merged

Fix replica selection runtime error in dashboard#2262
JamesNK merged 4 commits intomainfrom
jamesnk/fix-replica-runtime-error

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 16, 2024

#2123 introduced an error on console logs because it wasn't creating ReplicaTypeDetails for a replica. The razor file cast fails and creates an error.

  • Corrected created type on console page.
  • Added validation to the model that the right type is created.
Microsoft Reviewers: Open in CodeFlow

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Feb 16, 2024

@adamint please look at this. The console page is broken

@JamesNK JamesNK force-pushed the jamesnk/fix-replica-runtime-error branch from e98e014 to a92a58d Compare February 16, 2024 23:05
@JamesNK JamesNK enabled auto-merge (squash) February 16, 2024 23:51
@JamesNK JamesNK merged commit dc62079 into main Feb 17, 2024
@JamesNK JamesNK deleted the jamesnk/fix-replica-runtime-error branch February 17, 2024 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants