Fix ServiceBus endpoint logic#2385
Merged
eerhardt merged 1 commit intomicrosoft:mainfrom Feb 23, 2024
Merged
Conversation
In previous versions of the ServiceBus SDK, it didn't accept `https://` URIs as the fully qualified namespace, but the ResourceManager APIs only return URIs with `https://`. So we had logic in our bicep template to remove the https. However, this doesn't work with the runtime component because it expected sb://. The fix is to update to the latest ServiceBus version, which accepts https:// for the namespace URI. And also remove our bicp logic to just pass the endpoint through unmodified. Also clean up the Directory.Packages.props file. Fix microsoft#2378
ghost
added
the
area-integrations
davidfowl
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous versions of the ServiceBus SDK, it didn't accept
https://URIs as the fully qualified namespace, but the ResourceManager APIs only return URIs withhttps://. So we had logic in our bicep template to remove the https. However, this doesn't work with the runtime component because it expected sb://.The fix is to update to the latest ServiceBus version, which accepts https:// for the namespace URI. And also remove our bicp logic to just pass the endpoint through unmodified.
Also clean up the Directory.Packages.props file.
Fix #2378
Microsoft Reviewers: Open in CodeFlow