Clear selection on filter changes#2913
Merged
tlmii merged 1 commit intomicrosoft:mainfrom Mar 18, 2024
Merged
Conversation
tlmii
requested review from
JamesNK,
adamint,
drewnoakes and
leslierichardson95
ghost
added
the
Member
|
I think this could be improved by only clearing the selection if a filter is added/changed, and not if a filter is removed. For example:
Could do this in a future issue. |
JamesNK
approved these changes
Mar 18, 2024
Member
Author
Good call. Filed #2972 to track |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2776 by clearing the selection on Resources and Structured Logs when any of the filters change.
For now I did not try to retain the selection on either page if the selected item would still be visible after the filter. That was easy enough on Resources that always has a small non-paged dataset. But not as simple on Structured Logs where the filtered data set might still be extremely large (see #2776 (comment)). For consistency between the pages, I just cleared on both.
We can complete this PR as-is and see if feedback says we should try to maintain selection, or we can decide to do more. But I figured I'd start with this.
Microsoft Reviewers: Open in CodeFlow