[release/8.0-preview5] Make reading Kubeconfig from DCP resilient#3167
Merged
davidfowl merged 11 commits intorelease/8.0-preview5from Mar 26, 2024
Merged
Conversation
ghost
added
the
area-app-model
davidfowl
approved these changes
Mar 26, 2024
github-actions
Bot
force-pushed
the
backport/pr-3132-to-release/8.0-preview5
branch
from
3d15eb6 to
681342a
Compare
github-actions
Bot
force-pushed
the
backport/pr-3132-to-release/8.0-preview5
branch
from
681342a to
42e91f3
Compare
joperezr
approved these changes
Mar 26, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3132 to release/8.0-preview5
/cc @mitchdenny
Customer Impact
This PR backports a fix for race condition that exists when attempting to read the kubernetes configuration file that DCP drops down in a pre-arranged location. We launch DCP, and then in parallel a number of startup processes are attempting to get the kubeconfig file.
Testing
Tested manually using VS launch,
dotnet runanddotnet watch.Risk
Low. This PR introduces a timeout behavior but those settings can be tuned via configuration settings.
Microsoft Reviewers: Open in CodeFlow