[release/8.0-preview5] Update container runtime not found exception message#3225
Merged
DamianEdwards merged 2 commits intorelease/8.0-preview5from Mar 27, 2024
Merged
Conversation
ghost
added
the
area-app-model
joperezr
approved these changes
Mar 27, 2024
Member
|
As a tangent, we don't localize exception messages, right? |
timheuer
approved these changes
Mar 27, 2024
Member
They're in a resources resx so I assume the goal was to localize them at some point, otherwise, why bother to put them in resx at all? |
balachir
approved these changes
Mar 27, 2024
Member
|
Looks like we need to build after making this change in order to update the xlfs to request the translations. Can you take care of that @DamianEdwards ? |
Contributor
|
I think it's a bad practice to localise exception messages as those are developer facing, and when development teams get localised exceptions messages and stack traces they more often unable to help their peers. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3224 to release/8.0-preview5
/cc @DamianEdwards
Customer Impact
Testing
Risk
Microsoft Reviewers: Open in CodeFlow